1. 14 Sep, 2009 1 commit
  2. 09 Sep, 2009 1 commit
  3. 08 Sep, 2009 1 commit
    • Steven Whitehouse's avatar
      GFS2: Be extra careful about deallocating inodes · acf7e244
      Steven Whitehouse authored
      
      
      There is a potential race in the inode deallocation code if two
      nodes try to deallocate the same inode at the same time. Most of
      the issue is solved by the iopen locking. There is still a small
      window which is not covered by the iopen lock. This patches fixes
      that and also makes the deallocation code more robust in the face of
      any errors in the rgrp bitmaps, or erroneous iopen callbacks from
      other nodes.
      
      This does introduce one extra disk read, but that is generally not
      an issue since its the same block that must be written to later
      in the deallocation process. The total disk accesses therefore stay
      the same,
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      acf7e244
  4. 27 Aug, 2009 1 commit
    • Steven Whitehouse's avatar
      GFS2: Remove no_formal_ino generating code · 8d8291ae
      Steven Whitehouse authored
      
      
      The inum structure used throughout GFS2 has two fields. One
      no_addr is the disk block number of the inode in question and
      is used everywhere as the inode number. The other, no_formal_ino,
      is used only as the generation number for NFS.
      
      Historically the no_formal_ino field was set using a complicated
      system of one global and one per-node file containing inode numbers
      in order to ensure that each no_formal_ino was unique. Also this
      code made no provision for what would happen when eventually the
      (64 bit) numbers ran out. Now I know that is pretty unlikely to
      happen given the large space of numbers, but it is possible
      nevertheless.
      
      The only guarantee required for no_formal_ino is that, for any
      single inode, the same number doesn't get reused too quickly.
      
      We already have a generation number which is kept in the inode
      and initialised from a counter in the resource group (almost
      no overhead, since we have to touch the resource group anyway
      in order to allocate an inode in the first place). Aside from
      ensuring that we never use the value 0 in the no_formal_ino
      field, we can use that counter directly.
      
      As a result of that change, we lose about 200 lines of code and
      also gain about 10 creates/sec on the postmark benchmark (on
      my test machine).
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      8d8291ae
  5. 26 Aug, 2009 2 commits
    • Steven Whitehouse's avatar
      GFS2: Rename eattr.[ch] as xattr.[ch] · 307cf6e6
      Steven Whitehouse authored
      
      
      Use the more conventional name for the extended attribute
      support code. Update all the places which care.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      307cf6e6
    • Steven Whitehouse's avatar
      GFS2: Clean up of extended attribute support · 40b78a32
      Steven Whitehouse authored
      
      
      This has been on my list for some time. We need to change the way
      in which we handle extended attributes to allow faster file creation
      times (by reducing the number of transactions required) and the
      extended attribute code is the main obstacle to this.
      
      In addition to that, the VFS provides a way to demultiplex the xattr
      calls which we ought to be using, rather than rolling our own. This
      patch changes the GFS2 code to use that VFS feature and as a result
      the code shrinks by a couple of hundred lines or so, and becomes
      easier to read.
      
      I'm planning on doing further clean up work in this area, but this
      patch is a good start. The cleaned up code also uses the more usual
      "xattr" shorthand, I plan to eliminate the use of "eattr" eventually
      and in the mean time it serves as a flag as to which bits of the code
      have been updated.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      40b78a32
  6. 24 Aug, 2009 2 commits
  7. 18 Aug, 2009 1 commit
    • Wengang Wang's avatar
      GFS2: free disk inode which is deleted by remote node -V2 · 970343cd
      Wengang Wang authored
      this patch is for the same problem that Benjamin Marzinski fixes at commit
      b94a170e
      
      
      
      quotation of the original problem:
      
      ---cut here---
      When a file is deleted from a gfs2 filesystem on one node, a dcache
      entry for it may still exist on other nodes in the cluster. If this
      happens, gfs2 will be unable to free this file on disk. Because of this,
      it's possible to have a gfs2 filesystem with no files on it and no free
      space. With this patch, when a node receives a callback notifying it
      that the file is being deleted on another node, it schedules a new
      workqueue thread to remove the file's dcache entry.
      ---end cut---
      
      after applying Benjamin's patch, I think there is still a case in which the disk
      inode remains even when "no space" is hit. the case is that when running
      d_prune_aliases() against the inode, there are one or more dentries(aliases)
      which have reference count number > 0. in this case the dentries won't be pruned.
      and even later, the reference count becomes to 0, the dentries can still be
      cached in memory. unfortunately, no callback come again, things come back to
      the state before the callback runs. thus the on disk inode remains there until
      in memoryinode is removed for some other reason(shrinking inode cache or unmount
      the volume..).
      
      this patch is to remove those dentries when their reference count becomes to 0 and
      the inode is deleted by remote node. for implementation, gfs2_dentry_delete() is
      added as dentry_operations.d_delete. the function returns true when the inode is
      deleted by remote node. in dput(), gfs2_dentry_delete() is called and since it
      returns true, the dentry is unhashed from dcache and then removed. when all dentries
      are removed, the in memory inode get removed so that the on disk inode is freed.
      Signed-off-by: default avatarWengang Wang <wen.gang.wang@oracle.com>
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      970343cd
  8. 17 Aug, 2009 5 commits
  9. 14 Aug, 2009 1 commit
  10. 30 Jul, 2009 7 commits
  11. 13 Jul, 2009 1 commit
    • Li Zefan's avatar
      tracing/events: Move TRACE_SYSTEM outside of include guard · d0b6e04a
      Li Zefan authored
      
      
      If TRACE_INCLDUE_FILE is defined, <trace/events/TRACE_INCLUDE_FILE.h>
      will be included and compiled, otherwise it will be
      <trace/events/TRACE_SYSTEM.h>
      
      So TRACE_SYSTEM should be defined outside of #if proctection,
      just like TRACE_INCLUDE_FILE.
      
      Imaging this scenario:
      
       #include <trace/events/foo.h>
          -> TRACE_SYSTEM == foo
       ...
       #include <trace/events/bar.h>
          -> TRACE_SYSTEM == bar
       ...
       #define CREATE_TRACE_POINTS
       #include <trace/events/foo.h>
          -> TRACE_SYSTEM == bar !!!
      
      and then bar.h will be included and compiled.
      Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      LKML-Reference: <4A5A9CF1.2010007@cn.fujitsu.com>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      d0b6e04a
  12. 19 Jun, 2009 1 commit
  13. 12 Jun, 2009 2 commits
  14. 11 Jun, 2009 2 commits
  15. 10 Jun, 2009 2 commits
  16. 05 Jun, 2009 1 commit
  17. 03 Jun, 2009 1 commit
  18. 02 Jun, 2009 1 commit
  19. 26 May, 2009 2 commits
    • Steven Whitehouse's avatar
      GFS2: Remove args subdir from gfs2 sysfs files · f6eb5349
      Steven Whitehouse authored
      
      
      Since we can cat /proc/mounts there is no need to have this
      subdirectory in the gfs2 sysfs files. In fact this does not
      reflect the full range of possible mount argumenmts, where
      as /proc/mounts does.
      
      There was only one userland user of this set of sysfs files
      and it will function perfectly well without these files
      being present (in fact that subcommand of gfs2_tool is
      obsolete anyway).
      
      The tune/* subdirectory is also considered mostly obsolete,
      but there are a few uses of this until mount arguments can
      be added for the last few functions for which there are no
      equivalents currently. However the tune/* directory is still
      in my sights and new code should avoid using it. Only the gfs2_quota
      and gfs2_tool programs are know to use tune/* at the moment.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      f6eb5349
    • Steven Whitehouse's avatar
      GFS2: Remove lockstruct subdir from gfs2 sysfs files · e1b28aab
      Steven Whitehouse authored
      
      
      The lockstruct sub directory contained two entries, both of
      which are duplicated elsewhere in the gfs2 sysfs files as
      well as being available via /proc/mounts. There is no userland program
      using either of them, so this patch removes them.
      Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
      e1b28aab
  20. 22 May, 2009 5 commits