1. 18 Jan, 2011 1 commit
    • Romain Francoise's avatar
      ipv6: Silence privacy extensions initialization · 2fdc1c80
      Romain Francoise authored
      
      
      When a network namespace is created (via CLONE_NEWNET), the loopback
      interface is automatically added to the new namespace, triggering a
      printk in ipv6_add_dev() if CONFIG_IPV6_PRIVACY is set.
      
      This is problematic for applications which use CLONE_NEWNET as
      part of a sandbox, like Chromium's suid sandbox or recent versions of
      vsftpd. On a busy machine, it can lead to thousands of useless
      "lo: Disabled Privacy Extensions" messages appearing in dmesg.
      
      It's easy enough to check the status of privacy extensions via the
      use_tempaddr sysctl, so just removing the printk seems like the most
      sensible solution.
      Signed-off-by: default avatarRomain Francoise <romain@orebokech.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2fdc1c80
  2. 18 Dec, 2010 1 commit
  3. 16 Dec, 2010 1 commit
  4. 10 Dec, 2010 1 commit
  5. 27 Nov, 2010 1 commit
    • Thomas Graf's avatar
      rtnl: make link af-specific updates atomic · cf7afbfe
      Thomas Graf authored
      
      
      As David pointed out correctly, updates to af-specific attributes
      are currently not atomic. If multiple changes are requested and
      one of them fails, previous updates may have been applied already
      leaving the link behind in a undefined state.
      
      This patch splits the function parse_link_af() into two functions
      validate_link_af() and set_link_at(). validate_link_af() is placed
      to validate_linkmsg() check for errors as early as possible before
      any changes to the link have been made. set_link_af() is called to
      commit the changes later.
      
      This method is not fail proof, while it is currently sufficient
      to make set_link_af() inerrable and thus 100% atomic, the
      validation function method will not be able to detect all error
      scenarios in the future, there will likely always be errors
      depending on states which are f.e. not protected by rtnl_mutex
      and thus may change between validation and setting.
      
      Also, instead of silently ignoring unknown address families and
      config blocks for address families which did not register a set
      function the errors EAFNOSUPPORT respectively EOPNOSUPPORT are
      returned to avoid comitting 4 out of 5 update requests without
      notifying the user.
      Signed-off-by: default avatarThomas Graf <tgraf@infradead.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cf7afbfe
  6. 22 Nov, 2010 1 commit
  7. 18 Nov, 2010 2 commits
  8. 17 Nov, 2010 1 commit
  9. 16 Nov, 2010 1 commit
  10. 12 Nov, 2010 1 commit
    • Lorenzo Colitti's avatar
      ipv6: addrconf: don't remove address state on ifdown if the address is being kept · 2de79570
      Lorenzo Colitti authored
      
      
      Currently, addrconf_ifdown does not delete statically configured IPv6
      addresses when the interface is brought down. The intent is that when
      the interface comes back up the address will be usable again. However,
      this doesn't actually work, because the system stops listening on the
      corresponding solicited-node multicast address, so the address cannot
      respond to neighbor solicitations and thus receive traffic. Also, the
      code notifies the rest of the system that the address is being deleted
      (e.g, RTM_DELADDR), even though it is not. Fix it so that none of this
      state is updated if the address is being kept on the interface.
      
      Tested: Added a statically configured IPv6 address to an interface,
      started ping, brought link down, brought link up again. When link came
      up ping kept on going and "ip -6 maddr" showed that the host was still
      subscribed to there
      Signed-off-by: default avatarLorenzo Colitti <lorenzo@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2de79570
  11. 27 Oct, 2010 1 commit
  12. 26 Oct, 2010 2 commits
    • Glenn Wurster's avatar
      IPv6: Temp addresses are immediately deleted. · 7a876b0e
      Glenn Wurster authored
      
      
      There is a bug in the interaction between ipv6_create_tempaddr and
      addrconf_verify.  Because ipv6_create_tempaddr uses the cstamp and tstamp
      from the public address in creating a private address, if we have not
      received a router advertisement in a while, tstamp + temp_valid_lft might be
      < now.  If this happens, the new address is created inside
      ipv6_create_tempaddr, then the loop within addrconf_verify starts again and
      the address is immediately deleted.  We are left with no temporary addresses
      on the interface, and no more will be created until the public IP address is
      updated.  To avoid this, set the expiry time to be the minimum of the time
      left on the public address or the config option PLUS the current age of the
      public interface.
      Signed-off-by: default avatarGlenn Wurster <gwurster@scs.carleton.ca>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7a876b0e
    • Glenn Wurster's avatar
      IPv6: Create temporary address if none exists. · aed65501
      Glenn Wurster authored
      
      
      If privacy extentions are enabled, but no current temporary address exists,
      then create one when we get a router advertisement.
      Signed-off-by: default avatarGlenn Wurster <gwurster@scs.carleton.ca>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      aed65501
  13. 05 Oct, 2010 1 commit
  14. 26 Sep, 2010 1 commit
    • Neil Horman's avatar
      ipv6: add a missing unregister_pernet_subsys call · 2cc6d2bf
      Neil Horman authored
      
      
      Clean up a missing exit path in the ipv6 module init routines.  In
      addrconf_init we call ipv6_addr_label_init which calls register_pernet_subsys
      for the ipv6_addr_label_ops structure.  But if module loading fails, or if the
      ipv6 module is removed, there is no corresponding unregister_pernet_subsys call,
      which leaves a now-bogus address on the pernet_list, leading to oopses in
      subsequent registrations.  This patch cleans up both the failed load path and
      the unload path.  Tested by myself with good results.
      Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
      
       include/net/addrconf.h |    1 +
       net/ipv6/addrconf.c    |   11 ++++++++---
       net/ipv6/addrlabel.c   |    5 +++++
       3 files changed, 14 insertions(+), 3 deletions(-)
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2cc6d2bf
  15. 23 Sep, 2010 1 commit
  16. 03 Sep, 2010 1 commit
  17. 22 Jul, 2010 1 commit
  18. 30 Jun, 2010 3 commits
  19. 25 Jun, 2010 1 commit
    • Eric Dumazet's avatar
      snmp: add align parameter to snmp_mib_init() · 1823e4c8
      Eric Dumazet authored
      
      
      In preparation for 64bit snmp counters for some mibs,
      add an 'align' parameter to snmp_mib_init(), instead
      of assuming mibs only contain 'unsigned long' fields.
      
      Callers can use __alignof__(type) to provide correct
      alignment.
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      CC: Herbert Xu <herbert@gondor.apana.org.au>
      CC: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
      CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
      CC: Vlad Yasevich <vladislav.yasevich@hp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1823e4c8
  20. 11 Jun, 2010 1 commit
  21. 18 May, 2010 4 commits
  22. 17 May, 2010 1 commit
  23. 03 May, 2010 1 commit
  24. 20 Apr, 2010 1 commit
  25. 13 Apr, 2010 4 commits
  26. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  27. 26 Mar, 2010 1 commit
  28. 25 Mar, 2010 2 commits
  29. 20 Mar, 2010 1 commit