1. 30 Jun, 2006 2 commits
    • Doug Thompson's avatar
      [PATCH] EDAC: mc numbers refactor 1-of-2 · 2d7bbb91
      Doug Thompson authored
      
      
      Remove add_mc_to_global_list().  In next patch, this function will be
      reimplemented with different semantics.
      
      1 Reimplement add_mc_to_global_list() with semantics that allow the caller to
        determine the ID number for a mem_ctl_info structure.  Then modify
        edac_mc_add_mc() so that the caller specifies the ID number for the new
        mem_ctl_info structure.  Platform-specific code should be able to assign the
        ID numbers in a platform-specific manner.  For instance, on Opteron it makes
        sense to have the ID of the mem_ctl_info structure match the ID of the node
        that the memory controller belongs to.
      
      2 Modify callers of edac_mc_add_mc() so they use the new semantics.
      Signed-off-by: default avatarDoug Thompson <norsk5@xmission.com>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      2d7bbb91
    • Doug Thompson's avatar
      [PATCH] EDAC: PCI device to DEVICE cleanup · 37f04581
      Doug Thompson authored
      
      
      Change MC drivers from using CVS revision strings for their version number,
      Now each driver has its own local string.
      
      Remove some PCI dependencies from the core EDAC module.  Made the code 'struct
      device' centric instead of 'struct pci_dev' Most of the code changes here are
      from a patch by Dave Jiang.  It may be best to eventually move the
      PCI-specific code into a separate source file.
      Signed-off-by: default avatarDoug Thompson <norsk5@xmission.com>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      37f04581
  2. 26 Mar, 2006 5 commits
    • Dave Peterson's avatar
      [PATCH] EDAC: formatting cleanup · e7ecd891
      Dave Peterson authored
      
      
      Cosmetic indentation/formatting cleanup for EDAC code.  Make sure we
      are using tabs rather than spaces to indent, etc.
      Signed-off-by: default avatarDavid S. Peterson <dsp@llnl.gov>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      e7ecd891
    • Dave Peterson's avatar
      [PATCH] EDAC: protect memory controller list · 18dbc337
      Dave Peterson authored
      
      
      - Fix code so we always hold mem_ctls_mutex while we are stepping
        through the list of mem_ctl_info structures.  Otherwise bad things
        may happen if one task is stepping through the list while another
        task is modifying it.  We may eventually want to use reference
        counting to manage the mem_ctl_info structures.  In the meantime we
        may as well fix this bug.
      
      - Don't disable interrupts while we are walking the list of
        mem_ctl_info structures in check_mc_devices().  This is unnecessary.
      Signed-off-by: default avatarDavid S. Peterson <dsp@llnl.gov>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      18dbc337
    • Dave Peterson's avatar
      [PATCH] EDAC: kobject/sysfs fixes · 472678eb
      Dave Peterson authored
      
      
      - After we unregister a kobject, wait for our kobject release method
        to call complete().  This causes us to wait until the kobject
        reference count reaches 0.  Otherwise, a task accessing the EDAC
        sysfs interface can hold the reference count above 0 until after the
        EDAC module has been unloaded.  When the reference count finally
        drops to 0, this will result in an attempt to call our release
        method inside the EDAC module after the module has already been
        unloaded.
      
        This isn't the best fix, since a process can get stuck sleeping forever
        uninterruptibly if the user does the following:
      
            rmmod my_module < /sys/my_sysfs/file
      
        I'll go back and implement a better fix later.  However this should
        be ok for now.
      
      - Call edac_remove_sysfs_mci_device() from edac_mc_del_mc() rather
        than from edac_mc_free().  Since edac_mc_add_mc() calls
        edac_create_sysfs_mci_device(), edac_mc_del_mc() should call
        edac_remove_sysfs_mci_device().
      Signed-off-by: default avatarDavid S. Peterson <dsp@llnl.gov>
      Cc: Greg KH <greg@kroah.com>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      472678eb
    • Dave Peterson's avatar
      [PATCH] EDAC: name cleanup · 680cbbbb
      Dave Peterson authored
      
      
      Perform the following name substitutions on all source files:
      
          sed 's/BS_MOD_STR/EDAC_MOD_STR/g'
          sed 's/bs_thread_info/edac_thread_info/g'
          sed 's/bs_thread/edac_thread/g'
          sed 's/bs_xstr/edac_xstr/g'
          sed 's/bs_str/edac_str/g'
      
      The names that start with BS_ or bs_ are artifacts of when the code
      was called "bluesmoke".
      Signed-off-by: default avatarDavid S. Peterson <dsp@llnl.gov>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      680cbbbb
    • Dave Peterson's avatar
      [PATCH] EDAC: printk cleanup · 537fba28
      Dave Peterson authored
      
      
      This implements the following idea:
      
      On Monday 30 January 2006 19:22, Eric W. Biederman wrote:
      > One piece missing from this conversation is the issue that we need errors
      > in a uniform format.  That is why edac_mc has helper functions.
      >
      > However there will always be errors that don't fit any particular model.
      > Could we add a edac_printk(dev, );  That is similar to dev_printk but
      > prints out an EDAC header and the device on which the error was found?
      > Letting the rest of the string be user specified.
      >
      > For actual control that interface may be to blunt, but at least for people
      > looking in the logs it allows all of the errors to be detected and
      > harvested.
      Signed-off-by: default avatarDavid S. Peterson <dsp@llnl.gov>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      537fba28
  3. 18 Jan, 2006 1 commit