1. 25 Jul, 2011 1 commit
  2. 17 Jul, 2011 2 commits
  3. 06 Jun, 2011 1 commit
  4. 25 May, 2011 1 commit
    • Sean Hefty's avatar
      RDMA/cma: Pass QP type into rdma_create_id() · b26f9b99
      Sean Hefty authored
      The RDMA CM currently infers the QP type from the port space selected
      by the user.  In the future (eg with RDMA_PS_IB or XRC), there may not
      be a 1-1 correspondence between port space and QP type.  For netlink
      export of RDMA CM state, we want to export the QP type to userspace,
      so it is cleaner to explicitly associate a QP type to an ID.
      Modify rdma_create_id() to allow the user to specify the QP type, and
      use it to make our selections of datagram versus connected mode.
      Signed-off-by: default avatarSean Hefty <sean.hefty@intel.com>
      Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
  5. 10 May, 2011 1 commit
  6. 17 Mar, 2011 1 commit
  7. 15 Mar, 2011 1 commit
  8. 11 Mar, 2011 2 commits
    • Tom Tucker's avatar
      RPCRDMA: Fix FRMR registration/invalidate handling. · 5c635e09
      Tom Tucker authored
      When the rpc_memreg_strategy is 5, FRMR are used to map RPC data.
      This mode uses an FRMR to map the RPC data, then invalidates
      (i.e. unregisers) the data in xprt_rdma_free. These FRMR are used
      across connections on the same mount, i.e. if the connection goes
      away on an idle timeout and reconnects later, the FRMR are not
      destroyed and recreated.
      This creates a problem for transport errors because the WR that
      invalidate an FRMR may be flushed (i.e. fail) leaving the
      FRMR valid. When the FRMR is later used to map an RPC it will fail,
      tearing down the transport and starting over. Over time, more and
      more of the FRMR pool end up in the wrong state resulting in
      seemingly random disconnects.
      This fix keeps track of the FRMR state explicitly by setting it's
      state based on the successful completion of a reg/inv WR. If the FRMR
      is ever used and found to be in the wrong state, an invalidate WR
      is prepended, re-syncing the FRMR state and avoiding the connection loss.
      Signed-off-by: default avatarTom Tucker <tom@ogc.us>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    • Tom Tucker's avatar
      RPCRDMA: Fix to XDR page base interpretation in marshalling logic. · bd7ea31b
      Tom Tucker authored
      The RPCRDMA marshalling logic assumed that xdr->page_base was an
      offset into the first page of xdr->page_list. It is in fact an
      offset into the xdr->page_list itself, that is, it selects the
      first page in the page_list and the offset into that page.
      The symptom depended in part on the rpc_memreg_strategy, if it was
      FRMR, or some other one-shot mapping mode, the connection would get
      torn down on a base and bounds error. When the badly marshalled RPC
      was retransmitted it would reconnect, get the error, and tear down the
      connection again in a loop forever. This resulted in a hung-mount. For
      the other modes, it would result in silent data corruption. This bug is
      most easily reproduced by writing more data than the filesystem
      has space for.
      This fix corrects the page_base assumption and otherwise simplifies
      the iov mapping logic.
      Signed-off-by: default avatarTom Tucker <tom@ogc.us>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
  9. 10 Mar, 2011 1 commit
  10. 21 Oct, 2010 1 commit
    • Tejun Heo's avatar
      sunrpc/xprtrdma: clean up workqueue usage · a25e758c
      Tejun Heo authored
      * Create and use svc_rdma_wq instead of using the system workqueue and
        flush_scheduled_work().  This workqueue is necessary to serve as
        flushing domain for rdma->sc_work which is used to destroy itself
        and thus can't be flushed explicitly.
      * Replace cancel_delayed_work() + flush_scheduled_work() with
      * Implement synchronous connect in xprt_rdma_connect() using
        flush_delayed_work() on the rdma_connect work instead of using
      This is to prepare for the deprecation and removal of
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
  11. 18 Oct, 2010 2 commits
  12. 01 Oct, 2010 4 commits
  13. 11 Aug, 2010 2 commits
  14. 14 May, 2010 3 commits
  15. 03 May, 2010 1 commit
    • Neil Brown's avatar
      sunrpc: centralise most calls to svc_xprt_received · b48fa6b9
      Neil Brown authored
      svc_xprt_received must be called when ->xpo_recvfrom has finished
      receiving a message, so that the XPT_BUSY flag will be cleared and
      if necessary, requeued for further work.
      This call is currently made in each ->xpo_recvfrom function, often
      from multiple different points.  In each case it is the earliest point
      on a particular path where it is known that the protection provided by
      XPT_BUSY is no longer needed.
      However there are (still) some error paths which do not call
      svc_xprt_received, and requiring each ->xpo_recvfrom to make the call
      does not encourage robustness.
      So: move the svc_xprt_received call to be made just after the
      call to ->xpo_recvfrom(), and move it of the various ->xpo_recvfrom
      This means that it may not be called at the earliest possible instant,
      but this is unlikely to be a measurable performance issue.
      Note that there are still other calls to svc_xprt_received as it is
      also needed when an xprt is newly created.
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
  16. 05 Apr, 2010 1 commit
  17. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  18. 08 Mar, 2010 2 commits
  19. 04 Dec, 2009 1 commit
  20. 29 Nov, 2009 1 commit
  21. 18 Nov, 2009 1 commit
  22. 12 Nov, 2009 1 commit
    • Eric W. Biederman's avatar
      sysctl net: Remove unused binary sysctl code · f8572d8f
      Eric W. Biederman authored
      Now that sys_sysctl is a compatiblity wrapper around /proc/sys
      all sysctl strategy routines, and all ctl_name and strategy
      entries in the sysctl tables are unused, and can be
      In addition neigh_sysctl_register has been modified to no longer
      take a strategy argument and it's callers have been modified not
      to pass one.
      Cc: "David Miller" <davem@davemloft.net>
      Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
  23. 11 Oct, 2009 1 commit
  24. 24 Sep, 2009 1 commit
  25. 09 Aug, 2009 3 commits
  26. 03 Jul, 2009 1 commit
  27. 15 Jun, 2009 1 commit
  28. 27 May, 2009 1 commit