1. 23 Apr, 2013 1 commit
  2. 22 Apr, 2013 4 commits
    • Daniel Borkmann's avatar
      net: sctp: minor: remove dead code from sctp_packet · 3e3251b3
      Daniel Borkmann authored
      struct sctp_packet is currently embedded into sctp_transport or
      sits on the stack as 'singleton' in sctp_outq_flush(). Therefore,
      its member 'malloced' is always 0, thus a kfree() is never called.
      Because of that, we can just remove this code.
      Signed-off-by: default avatarDaniel Borkmann <dborkman@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3e3251b3
    • Eric Dumazet's avatar
      net: remove a stale comment for dl_next · 3fb62c5d
      Eric Dumazet authored
      dl_next member in struct request_sock doesn't need to be first.
      
      We expect to insert a "struct common_sock" or a subset of it,
      so this claim had to be verified.
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3fb62c5d
    • Wei Liu's avatar
      xen-netback: coalesce slots in TX path and fix regressions · 2810e5b9
      Wei Liu authored
      This patch tries to coalesce tx requests when constructing grant copy
      structures. It enables netback to deal with situation when frontend's
      MAX_SKB_FRAGS is larger than backend's MAX_SKB_FRAGS.
      
      With the help of coalescing, this patch tries to address two regressions
      avoid reopening the security hole in XSA-39.
      
      Regression 1. The reduction of the number of supported ring entries (slots)
      per packet (from 18 to 17). This regression has been around for some time but
      remains unnoticed until XSA-39 security fix. This is fixed by coalescing
      slots.
      
      Regression 2. The XSA-39 security fix turning "too many frags" errors from
      just dropping the packet to a fatal error and disabling the VIF. This is fixed
      by coalescing slots (handling 18 slots when backend's MAX_SKB_FRAGS is 17)
      which rules out false positive (using 18 slots is legit) and dropping packets
      using 19 to `max_skb_slots` slots.
      
      To avoid reopening security hole in XSA-39, frontend sending packet using more
      than max_skb_slots is considered malicious.
      
      The behavior of netback for packet is thus:
      
          1-18            slots: valid
         19-max_skb_slots slots: drop and respond with an error
         max_skb_slots+   slots: fatal error
      
      max_skb_slots is configurable by admin, default value is 20.
      
      Also change variable name from "frags" to "slots" in netbk_count_requests.
      
      Please note that RX path still has dependency on MAX_SKB_FRAGS. This will be
      fixed with separate patch.
      Signed-off-by: default avatarWei Liu <wei.liu2@citrix.com>
      Acked-by: default avatarIan Campbell <ian.campbell@citrix.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2810e5b9
    • Wei Liu's avatar
      xen-netfront: reduce gso_max_size to account for max TCP header · 9ecd1a75
      Wei Liu authored
      The maximum packet including header that can be handled by netfront / netback
      wire format is 65535. Reduce gso_max_size accordingly.
      
      Drop skb and print warning when skb->len > 65535. This can 1) save the effort
      to send malformed packet to netback, 2) help spotting misconfiguration of
      netfront in the future.
      Signed-off-by: default avatarWei Liu <wei.liu2@citrix.com>
      Acked-by: default avatarIan Campbell <ian.campbell@citrix.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9ecd1a75
  3. 21 Apr, 2013 1 commit
  4. 20 Apr, 2013 1 commit
  5. 19 Apr, 2013 15 commits
  6. 18 Apr, 2013 2 commits
    • Eric Dumazet's avatar
      tcp: introduce TCPSpuriousRtxHostQueues SNMP counter · 0e280af0
      Eric Dumazet authored
      Host queues (Qdisc + NIC) can hold packets so long that TCP can
      eventually retransmit a packet before the first transmit even left
      the host.
      
      Its not clear right now if we could avoid this in the first place :
      
      - We could arm RTO timer not at the time we enqueue packets, but
        at the time we TX complete them (tcp_wfree())
      
      - Cancel the sending of the new copy of the packet if prior one
        is still in queue.
      
      This patch adds instrumentation so that we can at least see how
      often this problem happens.
      
      TCPSpuriousRtxHostQueues SNMP counter is incremented every time
      we detect the fast clone is not yet freed in tcp_transmit_skb()
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Cc: Yuchung Cheng <ycheng@google.com>
      Cc: Neal Cardwell <ncardwell@google.com>
      Cc: Tom Herbert <therbert@google.com>
      Cc: Willem de Bruijn <willemb@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0e280af0
    • Linus Torvalds's avatar
      Revert "block: add missing block_bio_complete() tracepoint" · 0a82a8d1
      Linus Torvalds authored
      This reverts commit 3a366e61.
      
      Wanlong Gao reports that it causes a kernel panic on his machine several
      minutes after boot. Reverting it removes the panic.
      
      Jens says:
       "It's not quite clear why that is yet, so I think we should just revert
        the commit for 3.9 final (which I'm assuming is pretty close).
      
        The wifi is crap at the LSF hotel, so sending this email instead of
        queueing up a revert and pull request."
      Reported-by: default avatarWanlong Gao <gaowanlong@cn.fujitsu.com>
      Requested-by: default avatarJens Axboe <axboe@kernel.dk>
      Cc: Tejun Heo <tj@kernel.org>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      0a82a8d1
  7. 17 Apr, 2013 9 commits
  8. 16 Apr, 2013 3 commits
    • Linus Torvalds's avatar
      vm: add vm_iomap_memory() helper function · b4cbb197
      Linus Torvalds authored
      Various drivers end up replicating the code to mmap() their memory
      buffers into user space, and our core memory remapping function may be
      very flexible but it is unnecessarily complicated for the common cases
      to use.
      
      Our internal VM uses pfn's ("page frame numbers") which simplifies
      things for the VM, and allows us to pass physical addresses around in a
      denser and more efficient format than passing a "phys_addr_t" around,
      and having to shift it up and down by the page size.  But it just means
      that drivers end up doing that shifting instead at the interface level.
      
      It also means that drivers end up mucking around with internal VM things
      like the vma details (vm_pgoff, vm_start/end) way more than they really
      need to.
      
      So this just exports a function to map a certain physical memory range
      into user space (using a phys_addr_t based interface that is much more
      natural for a driver) and hides all the complexity from the driver.
      Some drivers will still end up tweaking the vm_page_prot details for
      things like prefetching or cacheability etc, but that's actually
      relevant to the driver, rather than caring about what the page offset of
      the mapping is into the particular IO memory region.
      Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      b4cbb197
    • Atzm Watanabe's avatar
      vxlan: Allow setting destination to unicast address. · c7995c43
      Atzm Watanabe authored
      This patch allows setting VXLAN destination to unicast address.
      It allows that VXLAN can be used as peer-to-peer tunnel without
      multicast.
      
      v4: generalize struct vxlan_dev, "gaddr" is replaced with vxlan_rdst.
          "GROUP" attribute is replaced with "REMOTE".
          they are based by David Stevens's comments.
      
      v3: move a new attribute REMOTE into the last of an enum list
          based by Stephen Hemminger's comments.
      
      v2: use a new attribute REMOTE instead of GROUP based by
          Cong Wang's comments.
      Signed-off-by: default avatarAtzm Watanabe <atzm@stratosphere.co.jp>
      Acked-by: default avatarDavid L Stevens <dlstevens@us.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c7995c43
    • Sascha Herrmann's avatar
      at86rf230: add irq type configuration option · 43b5abe0
      Sascha Herrmann authored
      Add option to at86rf230 platform data to configure the type of the
      interrupt used by the driver. The irq polarity of the device will
      be configured accordingly.
      Signed-off-by: default avatarSascha Herrmann <sascha@ps.nvbi.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      43b5abe0
  9. 15 Apr, 2013 4 commits