1. 29 Aug, 2008 2 commits
    • Mattias Nissler's avatar
      rt2x00: Only configure hardware when radio is enabled · 2575c11d
      Mattias Nissler authored
      Some hardware configuration registers such as antenna and channel configuration
      can only be written when the radio is enabled. Previously, we didn't consider
      this, so some configuration items could be set inconsistently after reenabling
      the radio. This patch changes the config() handler to only reprogram the
      hardware when the radio is enabled. Configuration changes that are made while
      the radio is off are postponed until the radio is switched back on. We also
      leave the radio turned off during initialization and only enable it when
      requested by mac80211. This allows us to get rid of the DIRTY_CONFIG flag,
      because the device is now guaranteed to be completely initialized when brought
      up by mac80211.
      Signed-off-by: default avatarMattias Nissler <mattias.nissler@gmx.de>
      Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      2575c11d
    • Ivo van Doorn's avatar
      rt2x00: Fix race conditions in flag handling · 0262ab0d
      Ivo van Doorn authored
      Some of the flags should be accessed atomically to
      prevent race conditions. The flags that are most important
      are those that can change often and indicate the actual
      state of the device, queue or queue entry.
      
      The big flag rename was done to move all state flags to
      the same naming type as the other rt2x00dev flags and
      made sure all places where the flags were used were changed. ;)
      
      Thanks to Stephen for most of the queue flags updates,
      which fixes some of the most obvious consequences of the
      race conditions. Among those the notorious:
      
      rt2x00queue_write_tx_frame: Error - Arrived at non-free entry in the non-full queue 0.
      rt2x00queue_write_tx_frame: Error - Arrived at non-free entry in the non-full queue 0.
      rt2x00queue_write_tx_frame: Error - Arrived at non-free entry in the non-full queue 0.
      Signed-off-by: default avatarStephen Blackheath <tramp.enshrine.stephen@blacksapphire.com>
      Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      0262ab0d
  2. 22 Aug, 2008 5 commits
  3. 01 Aug, 2008 1 commit
  4. 29 Jul, 2008 2 commits
    • Ivo van Doorn's avatar
      rt2x00: Force full register config after start() · 74c0ee9b
      Ivo van Doorn authored
      rt2x00 will only perform configuration changes from
      mac80211 when the configuration option has changed.
      This means it keeps track of the current active configuration
      and will check these values when the config() callback function
      is used.
      
      However this causes breakage when the interface has been
      brought down and up again, since all stored active values
      aren't reset while the registers might have.
      This is for example the case with rt61pci antenna registers which
      will jump to invalid values when the interface has been started.
      
      To make sure a full configuration takes place after the start()
      callback function, a new flag is added which will be checked
      during config() and skips the "what's changed" phase.
      Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      74c0ee9b
    • Ivo van Doorn's avatar
      rt2x00: Fix EIFS timing value · f2fdbc48
      Ivo van Doorn authored
      Olivier reported a difference between the EIFS
      values used in the legacy driver and the one in
      the rt2x00 drivers.
      
      In rt2x00 the value was
      	( SIFS + (8 * (IEEE80211_HEADER + ACK_SIZE)) )
      which comes down to 314us while the legacy driver uses the value 364us
      
      This was caused because EIFS is: SIFS + DIFS + AckTime
      This patch will fix this by adding the DIFS by the above value,
      and creating a SHORT_EIFS define which uses the SHORT_DIFS.
      Reported-by: default avatarOlivier Cornu <o.cornu@gmail.com>
      Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      f2fdbc48
  5. 14 Jul, 2008 4 commits
  6. 10 Jul, 2008 1 commit
  7. 08 Jul, 2008 2 commits
  8. 27 Jun, 2008 1 commit
    • Ivo van Doorn's avatar
      rt2x00: Fix lock dependency errror · 980dfcb9
      Ivo van Doorn authored
      This fixes a circular locking dependency in the workqueue handling.
      The interface work task uses the mac80211 function
      ieee80211_iterate_active_interfaces() which grabs the RTNL lock.
      
      However when the interface is brough down, this happens under the RTNL
      lock as well, this causes problems because mac80211 will flush the workqueue
      during the ifdown event. This causes mac80211 to wait until the driver has
      completed all work which can't finish because it is waiting on the RTNL lock.
      
      This is fixed by moving rt2x00 workqueue tasks on a different workqueue,
      this workqueue can be flushed when the ieee80211_hw structure is removed
      by the driver (when the driver is unloaded) which does not happen under the
      RTNL lock.
      Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      980dfcb9
  9. 26 Jun, 2008 6 commits
  10. 14 Jun, 2008 4 commits
  11. 28 May, 2008 1 commit
  12. 21 May, 2008 5 commits
  13. 07 May, 2008 5 commits
  14. 01 Apr, 2008 1 commit