- 05 Feb, 2008 18 commits
-
-
Borislav Petkov authored
Spotted by Sergei Shtylyov. CC: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by:
Borislav Petkov <petkovbb@gmail.com> Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
Also, remove redundant ones and cleanup whitespace. Bart: - minor fixups Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
This function was being used only at one place so fold it in there. Signed-off-by:
-
Borislav Petkov authored
Shorten some member names not too aggressively since this driver might be gone anyway soon. Bart: - minor fixes Signed-off-by:
-
Borislav Petkov authored
- last_frame_position: only being written to once - firmware_revision, product_id, vendor_id: used once, remove from struct idetape_tape_t and deal with them locally - firmware_revision_num: only written to once - tape_still_time_begin: completely unused - tape_still_time: never written to; remove corresponding code chunk - uncontrolled_last_pipeline_head: only once written to - blocks_in_buffer: only written to Signed-off-by:
-
Borislav Petkov authored
.. and replace it with plain enums. Signed-off-by:
-
Borislav Petkov authored
... by adding a new typedef function pointer idetape_io_buf in order to call the proper buffer i/o handler depending on the data direction. Bart: - move idetape_io_buf before idetape_pc_intr() comment Signed-off-by:
-
Borislav Petkov authored
tape->speed_control is set to 1 in idetape_setup(), but, in calculate_speeds() its value is tested for being 0, 1, or 2. Remove the if-branches where tape->speed_control != 1 since they are never executed. Also, rename calculate_speeds() by adding driver's prefix as is with the other function names. Signed-off-by:
-
Borislav Petkov authored
There should be no functional changes resulting from this patch. Bart: - remove needless "!!" Signed-off-by:
-
Borislav Petkov authored
Teach the debug logging macro to differentiate between log levels based on the type of debug level enabled specifically instead of a threshold-based one. Thus, convert tape->debug_level to a bitmask that is written to over /proc. Also, - cleanup and simplify the debug macro thus removing a lot of code lines, - get rid of unused debug levels, - adjust the loglevel at several places where it was simply missing (e.g. idetape_chrdev_open()) - move the tape ptr initialization up in idetape_chrdev_open() so that we can use it in the debug_log macro earlier in the function. Signed-off-by:
-
Bartlomiej Zolnierkiewicz authored
Acked-by:
Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by:
-
Bartlomiej Zolnierkiewicz authored
Acked-by:
-
- 02 Feb, 2008 21 commits
-
-
Borislav Petkov authored
Since this is used only in idetape_blkdev_ioctl(), remove the typedef and make the struct function-local. Bart: - s/sizeof(struct idetape_config)/sizeof(config)/ Signed-off-by:
Borislav Petkov <bbpetkov@yahoo.de> Signed-off-by:
-
Borislav Petkov authored
Those are already in mtio.h. Bart: - undo 'unsigned int/unsigned long' -> 'uint/ulong' conversion Signed-off-by:
-
Borislav Petkov authored
idetape_active_next_stage() was rather ambiguous wrt its purpose. Make that more explicit and remove superfluous comment. Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
This is not a network driver. Signed-off-by:
-
Borislav Petkov authored
Also, remove those which weren't used. Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
They seem just to sit there completely unused. Signed-off-by:
-
Borislav Petkov authored
Also, shorten function name idetape_get_blocksize_from_block_descriptor() and move its definition up thereby getting rid of its forward declaration. Signed-off-by:
-
Borislav Petkov authored
There should be no functional changes resulting from this patch. Signed-off-by:
-
Borislav Petkov authored
There should be no functional changes resulting from this patch. Signed-off-by:
-
Borislav Petkov authored
There should be no functional changes resulting from this patch. Signed-off-by:
-
Borislav Petkov authored
All those 2-byte values denoting the different capabilities are being written to the local copy of the caps buffer without being converted to big endian for simplicity of usage and shorter code later. Also, we add some comments stating which are the fields of the caps page in question in order to alleviate the cryptic pointer casting exercises as in e.g. idetape_get_mode_sense_results(). There should be no functional changes resulting from this patch. Bart: - remove two needless "!!" Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
The device capabilities are probed for during device initialization so this info is available through proc/ioctl() und it is redundant here. Signed-off-by:
-
Bartlomiej Zolnierkiewicz authored
Cc: Borislav Petkov <bbpetkov@yahoo.de> Signed-off-by: -
Borislav Petkov authored
Bart: - remove 'capabilities->speed' chunk - re-add brackets to block_descrp assignment Signed-off-by:
-
Borislav Petkov authored
Bart: - remove unnecessary comment change - remove two needless "!!" Signed-off-by:
-
Borislav Petkov authored
Signed-off-by:
-
Borislav Petkov authored
Also, cleanup whitespace and update comments. Bart: - remove reference to drivers/block/ide.c - move driver documentation to Documentation/ide/ide-tape.txt Signed-off-by:
-
Bartlomiej Zolnierkiewicz authored
Acked-by:
-
- 01 Feb, 2008 1 commit
-
-
Bartlomiej Zolnierkiewicz authored
The last years stuff and a trip down memory lane... Signed-off-by:
-
