1. 10 Apr, 2012 2 commits
  2. 06 Mar, 2012 1 commit
  3. 22 Feb, 2012 1 commit
  4. 19 Dec, 2011 1 commit
  5. 28 Nov, 2011 6 commits
    • Nick Kossifidis's avatar
      ath5k: Renumber hw queue ids · b4cfb5d5
      Nick Kossifidis authored
      
      
      According to documentation higher DCUs have higher priority and should
      be used for beacons and CAB traffic. More specifically DCU 9 should be
      used for beacons and DCU 8 for CAB traffic, I assumed DCU 7 should be
      OK for UAPSD traffic.
      
      Note that DCU 8 and 9 are special because they can only be mapped to a single
      QCU each but since we use a 1:1 mapping between QCUs and DCUs anyway we don't
      have to change much.
      
      P.S. I also did a few related cleanups on qcu.c and ath5k.h
      
      Signed-off-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      b4cfb5d5
    • Nick Kossifidis's avatar
      ath5k: MRR support and 2GHz radio override belong in ah_capabilities · 86f62d9b
      Nick Kossifidis authored
      
      
      MRR support and 2GHz radio override belong in ah_capabilities and we
      should use them (e.g. so far  we used to set mrr descriptor without
      checking if MRR support is enabled + we checked for MRR support 2
      times, one by trying to set up an MRR descriptor and another one based
      on MAC version).
      
      Signed-off-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      86f62d9b
    • Nick Kossifidis's avatar
      ath5k: Cleanups v2 + add kerneldoc on all hw functions · c47faa36
      Nick Kossifidis authored
      
      
      No functional changes
      
      Add kernel doc for all ath5k_hw_* functions and strcucts. Also do some cleanup,
      rename ath5k_hw_init_beacon to ath5k_hw_init_beacon_timers, remove an unused
      variable from ath5k_hw_pcu_init and a few obsolete macros, mostly related to XR.
      
      Signed-off-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      c47faa36
    • Nick Kossifidis's avatar
      ath5k: Calibration re-work · ce169aca
      Nick Kossifidis authored
      
      
      Noise floor calibration does not interfere with traffic and should run more
      often as part of our "short calibration". The full calibration is not the
      noise floor calibration but the AGC + Gain_F (on RF5111 and RF5112) calibration
      and should run less often because it does interfere with traffic.
      
      So
      
      Short calibration -> I/Q & NF Calibration
      Long calibration -> Short + AGC + Gain_F
      
      This patch was for some time on my pub/ dir on www.kernel.org and has been tested
      by a few people and me. I think it's O.K. to go in.
      
      I also changed ah_calibration to ah_iq_cal_needed to make more sense.
      
      v2 Use a workqueue instead of a tasklet for calibration
      
      Signed-off-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      ce169aca
    • Nick Kossifidis's avatar
      ath5k: Add TXNOFRM to INT_TX_ALL · fea94807
      Nick Kossifidis authored
      
      
      Add TXNOFRM to INT_TX_ALL since it's a TX interrupt too.
      
      Signed-off-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      fea94807
    • Nick Kossifidis's avatar
      ath5k: Switch from read-and-clear to write-to-clear method when handling PISR/SISR registers · 7ff7c82e
      Nick Kossifidis authored
      
      
      Since card has 12 tx queues and we want to keep track of the interrupts
      per queue we can't fit all these interrupt bits on a single register.
      So we have 5 registers, the primary interrupt status register (PISR) and
      the 4 secondary interupt status registers (SISRs).
      
      In order to be able to read them all at once (atomic operation) Atheros
      introduced the Read-And-Clear registers to make things easier. So when
      reading RAC_PISR register, hw does a read on PISR and all SISRs, returns
      the value of PISR, copies all SISR values to their shadow copies (RAC_SISRx)
      and clears PISR and SISRs. This saves us from reading PISR/SISRs in a sequence.
      
      So far we 've used this approach and MadWiFi/Windows driver etc also used it
      for years.
      
      It turns out this operation is not atomic after all (at least not on all cards)
      That means it's possible to loose some interrupts because they came after the
      copy step and hw cleared them on the clean step !
      
      That's probably the reason we got missed beacons, got stuck queues etc and
      couldn't figure out what was going on.
      
      With this patch we switch from RaC operation to an alternative method (that
      makes more sense IMHO anyway, I just chose to be on the safe side so far).
      Instead of reading RAC registers, we read the normal PISR/SISR registers and
      clear any bits we got by writing them back on the register. This will clear only
      the bits we got on our read step and leave any new bits unaffected (at least
      that's what docs say). So if any new interrupts come up we won't miss it.
      
      I've tested this with an AR5213 and an AR2425 and it seems O.K.
      
      Many thanks to Adrian Chadd for debuging this and reviewing the patch !
      
      v2: Make sure we don't clear PISR bits that map to SISR generated interrupts
      (added a comment on the code for this)
      
      Signed-off-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      7ff7c82e
  6. 08 Aug, 2011 4 commits
  7. 22 Jul, 2011 2 commits
  8. 20 Jul, 2011 1 commit
    • Pavel Roskin's avatar
      ath5k: merge ath5k_hw and ath5k_softc · e0d687bd
      Pavel Roskin authored
      
      
      Both ath5k_hw and ath5k_softc represent one instance of the hardware.
      This duplication is historical and is not needed anymore.
      
      Keep the name "ath5k_hw" for the merged structure and "ah" for the
      variable pointing to it.  "ath5k_hw" is shorter than "ath5k_softc", more
      descriptive and more widely used.
      
      Put the combined structure to ath5k.h where the old ath5k_softc used to
      be. Move some code from base.h to ath5k.h as needed.
      
      Remove memory allocation for struct ath5k_hw and the corresponding error
      handling.  Merge iobase and ah_iobase fields.
      
      Signed-off-by: default avatarPavel Roskin <proski@gnu.org>
      Acked-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      e0d687bd
  9. 13 Jul, 2011 1 commit
  10. 11 Jul, 2011 1 commit
  11. 08 Jul, 2011 5 commits
  12. 17 Jun, 2011 1 commit
  13. 14 Apr, 2011 2 commits
  14. 12 Apr, 2011 6 commits
  15. 09 Mar, 2011 1 commit
  16. 25 Feb, 2011 1 commit
    • Johannes Berg's avatar
      mac80211: make tx() operation return void · 7bb45683
      Johannes Berg authored
      
      
      The return value of the tx operation is commonly
      misused by drivers, leading to errors. All drivers
      will drop frames if they fail to TX the frame, and
      they must also properly manage the queues (if they
      didn't, mac80211 would already warn).
      
      Removing the ability for drivers to return a BUSY
      value also allows significant cleanups of the TX
      TX handling code in mac80211.
      
      Note that this also fixes a bug in ath9k_htc, the
      old "return -1" there was wrong.
      
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      Tested-by: Sedat Dilek <sedat.dilek@googlemail.com> [ath5k]
      Acked-by: Gertjan van Wingerde <gwingerde@gmail.com> [rt2x00]
      Acked-by: Larry Finger <Larry.Finger@lwfinger.net> [b43, rtl8187, rtlwifi]
      Acked-by: Luciano Coelho <coelho@ti.com> [wl12xx]
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      7bb45683
  17. 18 Feb, 2011 1 commit
  18. 28 Jan, 2011 1 commit
    • Bruno Randolf's avatar
      ath5k: Fix short and long retry configuration · 76a9f6fd
      Bruno Randolf authored
      
      
      The register definition for retry configuration on AR5212 was wrong, and simply
      copied over from AR5210. Update the register definitions from the documentation.
      
      Let the short and long retries be configured from mac80211 and use the standard
      values of 7 and 4 by default. Also we need to make sure we don't export more
      retries than we are configured for to mac80211 (and the rate module) in
      hw->max_rate_tries.
      
      Also clean up the code by removing unused defines and variables and drop the
      different values for "station retries" - if these need to be different it can
      be handled tru ah_retry_long/short.
      
      Signed-off-by: default avatarBruno Randolf <br1@einfach.org>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      76a9f6fd
  19. 22 Dec, 2010 2 commits