1. 14 Sep, 2009 9 commits
    • Jiro SEKIBA's avatar
      nilfs2: stop using periodic write_super callback · 1dfa2710
      Jiro SEKIBA authored
      
      
      This removes nilfs_write_super and commit super block in nilfs
      internal thread, instead of periodic write_super callback.
      
      VFS layer calls ->write_super callback periodically.  However,
      it looks like that calling back is ommited when disk I/O is busy.
      And when cleanerd (nilfs GC) is runnig, disk I/O tend to be busy thus
      nilfs superblock is not synchronized as nilfs designed.
      
      To avoid it, syncing superblock by nilfs thread instead of pdflush.
      Signed-off-by: default avatarJiro SEKIBA <jir@unicus.jp>
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      1dfa2710
    • Jiro SEKIBA's avatar
      nilfs2: clean up nilfs_write_super · 79efdd94
      Jiro SEKIBA authored
      
      
      Separate conditions that check if syncing super block and alternative
      super block are required as inline functions to reuse the conditions.
      Signed-off-by: default avatarJiro SEKIBA <jir@unicus.jp>
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      79efdd94
    • Jiro SEKIBA's avatar
      nilfs2: fix disorder of nilfs_write_super in nilfs_sync_fs · 6233caa9
      Jiro SEKIBA authored
      
      
      This fixes disorder of nilfs_write_super in nilfs_sync_fs.  Commiting
      super block must be the end of the function so that every changes are
      reflected.
      
      ->sync_fs() is not called frequently so this makes nilfs_sync_fs call
      nilfs_commit_super instead of nilfs_write_super.
      Signed-off-by: default avatarJiro SEKIBA <jir@unicus.jp>
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      6233caa9
    • Jiro SEKIBA's avatar
      nilfs2: remove redundant super block commit · ec5d66ab
      Jiro SEKIBA authored
      
      
      This removes redundant super block commit.
      
      nilfs_write_super will call nilfs_commit_super to store super block
      into block device.  However, nilfs_put_super will call
      nilfs_commit_super right after calling nilfs_write_super.  So calling
      nilfs_write_super in nilfs_put_super would be redundant.
      Signed-off-by: default avatarJiro SEKIBA <jir@unicus.jp>
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      ec5d66ab
    • Jiro SEKIBA's avatar
      nilfs2: implement nilfs_show_options to display mount options in /proc/mounts · b58a285b
      Jiro SEKIBA authored
      
      
      This is a patch to display mount options in procfs.
      Mount options will show up in the /proc/mounts as other fs does.
      
      ...
      /dev/sda6 /mnt nilfs2 ro,relatime,barrier=off,cp=3,order=strict 0 0
      ...
      Signed-off-by: default avatarJiro SEKIBA <jir@unicus.jp>
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      b58a285b
    • Ryusuke Konishi's avatar
      nilfs2: always lookup disk block address before reading metadata block · 14351104
      Ryusuke Konishi authored
      
      
      The current metadata file code skips disk address lookup for its data
      block if the buffer has a mapped flag.
      
      This has a potential risk to cause read request to be performed
      against the stale block address that GC moved, and it may lead to meta
      data corruption.  The mapped flag is safe if the buffer has an
      uptodate flag, otherwise it may prevent necessary update of disk
      address in the next read.
      
      This will avoid the potential problem by ensuring disk address lookup
      before reading metadata block even for buffers with the mapped flag.
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      14351104
    • Ryusuke Konishi's avatar
      nilfs2: use semaphore to protect pointer to a writable FS-instance · 027d6404
      Ryusuke Konishi authored
      will get rid of nilfs_get_writer() and nilfs_put_writer() pair used to
      retain a writable FS-instance for a period.
      
      The pair functions were making up some kind of recursive lock with a
      mutex, but they became overkill since the commit
      201913ed
      
      .  Furthermore, they caused
      the following lockdep warning because the mutex can be released by a
      task which didn't lock it:
      
       =====================================
       [ BUG: bad unlock balance detected! ]
       -------------------------------------
       kswapd0/422 is trying to release lock (&nilfs->ns_writer_mutex) at:
       [<c1359ff5>] mutex_unlock+0x8/0xa
       but there are no more locks to release!
      
       other info that might help us debug this:
       no locks held by kswapd0/422.
      
       stack backtrace:
       Pid: 422, comm: kswapd0 Not tainted 2.6.31-rc4-nilfs #51
       Call Trace:
        [<c1358f97>] ? printk+0xf/0x18
        [<c104fea7>] print_unlock_inbalance_bug+0xcc/0xd7
        [<c11578de>] ? prop_put_global+0x3/0x35
        [<c1050195>] lock_release+0xed/0x1dc
        [<c1359ff5>] ? mutex_unlock+0x8/0xa
        [<c1359f83>] __mutex_unlock_slowpath+0xaf/0x119
        [<c1359ff5>] mutex_unlock+0x8/0xa
        [<d1284add>] nilfs_mdt_write_page+0xd8/0xe1 [nilfs2]
        [<c1092653>] shrink_page_list+0x379/0x68d
        [<c109171b>] ? isolate_pages_global+0xb4/0x18c
        [<c1092bd2>] shrink_list+0x26b/0x54b
        [<c10930be>] shrink_zone+0x20c/0x2a2
        [<c10936b7>] kswapd+0x407/0x591
        [<c1091667>] ? isolate_pages_global+0x0/0x18c
        [<c1040603>] ? autoremove_wake_function+0x0/0x33
        [<c10932b0>] ? kswapd+0x0/0x591
        [<c104033b>] kthread+0x69/0x6e
        [<c10402d2>] ? kthread+0x0/0x6e
        [<c1003e33>] kernel_thread_helper+0x7/0x1a
      
      This patch uses a reader/writer semaphore instead of the own lock and
      kills this warning.
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      027d6404
    • Heiko Carstens's avatar
      nilfs2: fix format string compile warning (ino_t) · b5696e5e
      Heiko Carstens authored
      
      
      Unlike on most other architectures ino_t is an unsigned int on s390.
      So add an explicit cast to avoid this compile warning:
      
      fs/nilfs2/recovery.c: In function 'recover_dsync_blocks':
      fs/nilfs2/recovery.c:555: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'ino_t'
      Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      b5696e5e
    • Ryusuke Konishi's avatar
      nilfs2: fix ignored error code in __nilfs_read_inode() · 1b2f5a64
      Ryusuke Konishi authored
      
      
      The __nilfs_read_inode function is ignoring the error code returned
      from nilfs_read_inode_common(), and wrongly delivers a success code
      (zero) when it escapes from the function in erroneous cases.
      
      This adds the missing error handling.
      Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
      1b2f5a64
  2. 09 Sep, 2009 2 commits
    • Linus Torvalds's avatar
      Linux 2.6.31 · 74fca6a4
      Linus Torvalds authored
      74fca6a4
    • Ed Cashin's avatar
      aoe: allocate unused request_queue for sysfs · 7135a71b
      Ed Cashin authored
      Andy Whitcroft reported an oops in aoe triggered by use of an
      incorrectly initialised request_queue object:
      
        [ 2645.959090] kobject '<NULL>' (ffff880059ca22c0): tried to add
      		an uninitialized object, something is seriously wrong.
        [ 2645.959104] Pid: 6, comm: events/0 Not tainted 2.6.31-5-generic #24-Ubuntu
        [ 2645.959107] Call Trace:
        [ 2645.959139] [<ffffffff8126ca2f>] kobject_add+0x5f/0x70
        [ 2645.959151] [<ffffffff8125b4ab>] blk_register_queue+0x8b/0xf0
        [ 2645.959155] [<ffffffff8126043f>] add_disk+0x8f/0x160
        [ 2645.959161] [<ffffffffa01673c4>] aoeblk_gdalloc+0x164/0x1c0 [aoe]
      
      The request queue of an aoe device is not used but can be allocated in
      code that does not sleep.
      
      Bruno bisected this regression down to
      
        cd43e26f
      
        block: Expose stacked device queues in sysfs
      
      "This seems to generate /sys/block/$device/queue and its contents for
       everyone who is using queues, not just for those queues that have a
       non-NULL queue->request_fn."
      
      Addresses http://bugs.launchpad.net/bugs/410198
      Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13942
      
      
      
      Note that embedding a queue inside another object has always been
      an illegal construct, since the queues are reference counted and
      must persist until the last reference is dropped. So aoe was
      always buggy in this respect (Jens).
      Signed-off-by: default avatarEd Cashin <ecashin@coraid.com>
      Cc: Andy Whitcroft <apw@canonical.com>
      Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
      Cc: Bruno Premont <bonbons@linux-vserver.org>
      Cc: Martin K. Petersen <martin.petersen@oracle.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
      7135a71b
  3. 08 Sep, 2009 2 commits
  4. 07 Sep, 2009 5 commits
  5. 06 Sep, 2009 3 commits
  6. 05 Sep, 2009 19 commits