1. 23 Mar, 2010 1 commit
    • Stephen Hemminger's avatar
      headerdep: perlcritic warning · 1dcd8100
      Stephen Hemminger authored
      Minor perlcritic warning:
      headerdep.pl: "return" statement with explicit "undef" at line 84, column 2.  See page 199 of PBP.  (Severity: 5)
      The rationale according to PBP is that an explicit return of undef
      (contrary to most people's expectations) doesn't
      always evaluate as false. It has to with the fact that perl return value
      depends on context the function is called. If function is used in
      list context, the appropriate return value for false is an empty list;
      whereas in scalar context the return value for false is undefined.
      By just using a "return" both cases are handled.
      In the context of a trivial script this doesn't matter. But one script
      may be cut-paste into later code (most people like me only know 50%
      of perl), that is why perlcritic always complains
      Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
  2. 11 Mar, 2010 1 commit
  3. 10 Mar, 2010 1 commit
  4. 08 Mar, 2010 2 commits
    • Michal Marek's avatar
      Revert "kbuild: specify absolute paths for cscope" · e93bc1a0
      Michal Marek authored
      This reverts commit eb8f844c. Ian
      Campbell writes:
      > I keep my kernel source tree on a more powerful build box where I run my
      > builds etc (including "make cscope") but run my editor from my
      > workstation with an NFS mount to the source. This worked fine for me
      > using relative paths for cscope. Using absolute paths in cscope breaks
      > this previously working setup because the root path is not the same on
      > both systems. I guess this is similar to moving the source tree around.
      > Without wanting to start a flamewar it really sounds to me like we are
      > working around a vim (or cscope) bug here, emacs with cscope bindings
      > works fine in this configuration.
      Given that absolute paths can be forced by make O=. cscope, change the
      default back to relative paths.
      Ian Campbell <ijc@hellion.org.uk>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
    • Michal Marek's avatar
      kbuild: Do not unnecessarily regenerate modules.builtin · a6c36632
      Michal Marek authored
      Only regenerate it if the configuration has changed. Also, do this after
      the modules build to fix errors with some weird Makefiles that are
      generated during build.
      Reported-by: default avatarEric Miao <eric.y.miao@gmail.com>
      Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
  5. 07 Mar, 2010 9 commits
  6. 03 Mar, 2010 25 commits
  7. 22 Feb, 2010 1 commit