1. 12 Mar, 2009 1 commit
  2. 21 Feb, 2009 1 commit
  3. 05 Aug, 2008 1 commit
  4. 30 Jul, 2008 1 commit
  5. 23 May, 2008 1 commit
    • Harvey Harrison's avatar
      scsi: fix integer as NULL pointer warning · 9bcf0910
      Harvey Harrison authored
      drivers/scsi/aha152x.c:3585:60: warning: Using plain integer as NULL pointer
      drivers/scsi/aha152x.c:3845:56: warning: Using plain integer as NULL pointer
      drivers/scsi/qla1280.c:2814:37: warning: Using plain integer as NULL pointer
      drivers/scsi/atp870u.c:750:47: warning: Using plain integer as NULL pointer
      drivers/scsi/3w-9xxx.c:1281:36: warning: Using plain integer as NULL pointer
      drivers/scsi/3w-9xxx.c:1293:36: warning: Using plain integer as NULL pointer
      drivers/scsi/3w-9xxx.c:1301:35: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:447:10: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:457:10: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:479:24: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:483:22: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:1213:23: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:1214:23: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
  6. 02 May, 2008 1 commit
    • Boaz Harrosh's avatar
      [SCSI] Let scsi_cmnd->cmnd use request->cmd buffer · 64a87b24
      Boaz Harrosh authored
       - struct scsi_cmnd had a 16 bytes command buffer of its own.
         This is an unnecessary duplication and copy of request's
         cmd. It is probably left overs from the time that scsi_cmnd
         could function without a request attached. So clean that up.
       - Once above is done, few places, apart from scsi-ml, needed
         adjustments due to changing the data type of scsi_cmnd->cmnd.
       - Lots of drivers still use MAX_COMMAND_SIZE. So I have left
         that #define but equate it to BLK_MAX_CDB. The way I see it
         and is reflected in the patch below is.
         MAX_COMMAND_SIZE - means: The longest fixed-length (*) SCSI CDB
                            as per the SCSI standard and is not related
                            to the implementation.
         BLK_MAX_CDB.     - The allocated space at the request level
       - I have audit all ISA drivers and made sure none use ->cmnd in a DMA
         Operation. Same audit was done by Andi Kleen.
      (*)fixed-length here means commands that their size can be determined
         by their opcode and the CDB does not carry a length specifier, (unlike
         the VARIABLE_LENGTH_CMD(0x7f) command). This is actually not exactly
         true and the SCSI standard also defines extended commands and
         vendor specific commands that can be bigger than 16 bytes. The kernel
         will support these using the same infrastructure used for VARLEN CDB's.
         So in effect MAX_COMMAND_SIZE means the maximum size command
         scsi-ml supports without specifying a cmd_len by ULD's
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
  7. 19 Apr, 2008 1 commit
  8. 07 Apr, 2008 2 commits
  9. 30 Jan, 2008 2 commits
  10. 23 Jan, 2008 1 commit
  11. 11 Jan, 2008 1 commit
  12. 17 Oct, 2007 1 commit
  13. 16 Oct, 2007 1 commit
  14. 12 Oct, 2007 1 commit
  15. 17 Jun, 2007 1 commit
  16. 05 Oct, 2006 1 commit
    • David Howells's avatar
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells authored
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      	struct pt_regs *old_regs = set_irq_regs(regs);
      And put the old one back at the end:
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      In timer_interrupt(), this sort of change will be necessary:
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      Some notes on the interrupt handling in the drivers:
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
       (*) Various IRQ handler function pointers have been moved to type
      Signed-Off-By: default avatarDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
  17. 19 Aug, 2006 1 commit
  18. 06 Aug, 2006 1 commit
  19. 28 Jul, 2006 1 commit
  20. 02 Jul, 2006 1 commit
  21. 19 Jun, 2006 2 commits
  22. 10 Jun, 2006 1 commit
    • HighPoint Linux Team's avatar
      [SCSI] hptiop: HighPoint RocketRAID 3xxx controller driver · ede1e6f8
      HighPoint Linux Team authored
      HighPoint RocketRAID 3220/3320 series 8 channel PCI-X SATA RAID Host
      Fixes from original submission:
      Merge Andrew Morton's patches:
      - Provide locking for global list
      - Fix debug printks
      - uninline function with multiple callsites
      - coding style fixups
      - remove unneeded casts of void*
      - kfree(NULL) is legal
      - Don't "succeed" if register_chrdev() failed - otherwise we'll later
        unregister a not-registered chrdev.
      - Don't return from hptiop_do_ioctl() with the spinlock held.
      - uninline __hpt_do_ioctl()
      Update for Arjan van de Ven's comments:
      - put all asm/ includes after the linux/ ones
      - replace mdelay with msleep
      - add pci posting flush
      - do not set pci command reqister in map_pci_bar
      - do not try merging sg elements in hptiop_buildsgl()
      - remove unused outstandingcommands member from hba structure
      - remove unimplemented hptiop_abort() handler
      - remove typedef u32 hpt_id_t
      Other updates:
      - fix endianess
      Signed-off-by: default avatarHighPoint Linux Team <linux@highpoint-tech.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>