- 22 Apr, 2011 2 commits
-
-
Johannes Berg authored
There's no point in running through iwl_down() when we never registered with mac80211, as it just cleans up internal structures that were never initialised in this case. Therefore we can also remove the special handling for this case from __iwl_down(). Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
Wey-Yi Guy <wey-yi.w.guy@intel.com>
-
Johannes Berg authored
The current code to read the error table header just hardcodes all the offsets, which is a bit hard to understand. We can read in the entire header (as much as we need) into a structure, and then take the data from there, which makes it easier to understand. To read a bigger blob we also don't need to grab NIC access for each word read, making the code more efficient. Signed-off-by:
-
- 18 Apr, 2011 4 commits
-
-
Wey-Yi Guy authored
After driver split, no need to use ieee80211_ops, remove it Signed-off-by: -
Johannes Berg authored
When testing some new P2P code, Angie found that the driver might crash because the beacon command ended up being bigger than a regular command. This is quite obvious -- a normal command is limited to roughly 360 bytes but a beacon may be much larger of course. To fix this, use the huge command buffer. Reported-by:
Angie Chinchilla <angie.v.chinchilla@intel.com> Signed-off-by:
-
Johannes Berg authored
There are a number of things in the driver that may result in a BUG(), which is suboptimal since it's hard to get debugging information out of the driver in that case and the user experience is also not good :-) Almost all BUG_ON instances can be converted to WARN_ON with a few lines of appropriate error handling, so do that instead. Signed-off-by:
-
Wey-Yi Guy authored
After driver split, no need to call led functions through callback Signed-off-by:
-
- 08 Apr, 2011 3 commits
-
-
Johannes Berg authored
If we maintain API properly, then there isn't really a reason to warn about this since we'll just be adding things that are safe to ignore, so downgrade the warning to debug info level. Signed-off-by:
-
Johannes Berg authored
There's no need to keep both normal and BT statistics versions around all the time in memory when we only use a subset of both. So keep only the subsets that we need in memory, depending on the debug config). Also, in doing so, we can remove all the calls to iwl_bt_statistics() in the driver as we'll just access the copied statistics now. Finally, also remove this call from the one place where it might still be needed and automatically detect what kind of statistics the device is sending based on their size. This way, we don't need to keep track of which devices do what any more, which is good since this is subject to change based on the ucode version (as some ucode even for non-BT devices will in fact use BT statistics). Warn upon encountering a statistics command from the ucode that isn't known, so we will find such issues earlier in the future. Signed-off-by:
Don Fry <donald.h.fry@intel.com> Signed-off-by:
-
Wey-Yi Guy authored
Remove broken_power_save checking Signed-off-by:
-
- 07 Apr, 2011 16 commits
-
-
Johannes Berg authored
This generates a massive reduction in module size: with debug: text data bss dec hex filename 670300 13136 420 683856 a6f50 iwlagn.ko (before) 388347 13136 408 401891 621e3 iwlagn.ko (after) without debug: text data bss dec hex filename 528575 13072 420 542067 84573 iwlagn.ko (before) 294192 13072 408 307672 4b1d8 iwlagn.ko (after) This also removes all the IO debug functionality since it can easily be replaced by tracing, and makes the code unnecessarily complex. I haven't done any CPU utilisation measurements, but given that the hotpaths don't use much IO it is not likely to have a negative impact; in fact, the size reduction will reduce cache pressure which possibly improves performance. Finally, an unused function or two were removed. Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Johannes Berg authored
The ISR (interrupt service routine) ops are now no longer necessary since they are the same for all devices this driver now handles. Signed-off-by:
-
Johannes Berg authored
The rev_id variable is only printed, we don't need to store it. Signed-off-by:
-
Johannes Berg authored
The hw_rev variable is used only during init, so there's no need to keep it around. Signed-off-by:
-
Johannes Berg authored
The variable is never used. Signed-off-by:
-
Johannes Berg authored
We know after loading the ucode whether it will support PAN or not, so we can also initialise the cmd_queue variable much earlier. Signed-off-by:
-
Johannes Berg authored
Devices newer than 4965 don't actually send two different versions of the ALIVE command, so we always had a bug here since before this patch we copy more data than we got. Remove the iwl_init_alive_resp struct and don't use it. Since we also really don't need to track all the data received in ALIVE as we only use the error and log event tables later, we can also save space by just keeping those and not more data around in memory. Signed-off-by:
-
Johannes Berg authored
Some new devices and microcode files will a greater variety of features, so the TLV-per-feature approach we took before will quickly make things harder to manage and increase the file size. Add a new TLV that has feature flags. Currently, it will contain: 1) a PAN feature flag, which moves from a separate TLV 2) a new BT stats bit that indicates whether the microcode image uses bluetooth statistics 3) a new MFP flag for management frame protection which can be enabled once the device/microcode supports it Signed-off-by: -
Wey-Yi Guy authored
Signed-off-by:
-
Johannes Berg authored
This was used only on 4965 in conjunction with the bootstrap ucode. Signed-off-by:
-
Johannes Berg authored
Only 4965 had a bootstrap microcode image, so the agn driver can completely ignore that and we can remove some code from it. Signed-off-by:
-
Johannes Berg authored
When we loaded a ucode, there's no point in checking any one that is present, we know which one is supposed to be present so also verify that it is exactly the right one. That also simplifies the code and makes it faster since it doesn't have to check all. Signed-off-by:
-
Johannes Berg authored
All agn devices behave the same, so there's no need to go through function pointers for any of the ucode loading functionality. Signed-off-by:
-
Johannes Berg authored
Now that these handlers are no longer shared between 4965 and agn, they can be static. Signed-off-by:
-
Stanislaw Gruszka authored
We now use priv->mutex to serialize sync command, remove old priv->sync_cmd_mutex and add assertion that priv->mutex must be locked. Signed-off-by:
Stanislaw Gruszka <sgruszka@redhat.com> Acked-by:
-
Stanislaw Gruszka authored
Check status bits with mutex taken, because when we wait for mutex unlock, status can change. Patch should also make remaining sync commands be send with priv->mutex taken. That will prevent execute these commands when we are currently reset firmware, what could possibly cause troubles. Signed-off-by:
-
- 30 Mar, 2011 1 commit
-
-
Dan Carpenter authored
We initialize exit_pending twice. It's the second initialization which is correct. That was added in d745d472 "iwlwifi: cancel scan when down the device". Signed-off-by:
Dan Carpenter <error27@gmail.com> Acked-by:
-
- 25 Mar, 2011 4 commits
-
-
Wey-Yi Guy authored
Number of deprecated module parameters need to be remove for 2.6.40 kernel Signed-off-by: -
Wey-Yi Guy authored
After driver split, remove the unused reference to 3945 and 4965 Signed-off-by: -
Wey-Yi Guy authored
After driver split, no need for support legacy isr, remove it. Signed-off-by: -
Johannes Berg authored
iwlagn's hardware scheduler needs to be set up with the right aggregation frame limit and buffer sizes. To achieve this, we need to move the hardware queue setup to when the session becomes operational. Tested-by:
Daniel Halperin <dhalperi@cs.washington.edu> Signed-off-by:
-
- 21 Mar, 2011 1 commit
-
-
Dan Carpenter authored
We should unlock here instead of returning -EINVAL directly. Signed-off-by:
-
- 11 Mar, 2011 1 commit
-
-
Johannes Berg authored
Add support to iwlagn for off-channel TX. The microcode API for this is a bit strange in that it uses a hacked-up scan command, so the scan code needs to change quite a bit to accomodate that and be able to send it out. Signed-off-by:
-
- 04 Mar, 2011 2 commits
-
-
Stanislaw Gruszka authored
Usually H/W generate statistics notify once per about 100ms, but sometimes we can receive notify in shorter time, even 2 ms. This can be problem for plcp health and ack health checking. I.e. with 2 plcp errors happens randomly in 2 ms duration, we exceed plcp delta threshold equal to 100 (2*100/2). Also checking ack's in short time, can results not necessary false positive and firmware reset, for example when channel is noised and we do not receive ACKs frames or when remote device does not send ACKs at the moment. Patch change code to do statistic check and possible recovery only if 99ms elapsed from last check. Forced delay should assure we have good statistic data to estimate hardware state. Signed-off-by:
-
Stanislaw Gruszka authored
Put generic rx_handlers (except iwlagn_rx_reply_compressed_ba) to iwl-rx.c . Make functions static and change prefix from iwlagn_ to iwl_ . Beautify iwl_setup_rx_handlers and do some other minor coding style changes. Signed-off-by:
-
- 28 Feb, 2011 3 commits
-
-
Sergei Shtylyov authored
Several more network drivers that read the device's revision ID from the PCI configuration register were merged after the commit 44c10138 (PCI: Change all drivers to use pci_device->revision), so it's time to do another pass of conversion to using the 'revision' field of 'struct pci_dev'... Signed-off-by:
Sergei Shtylyov <sshtylyov@ru.mvista.com> Acked-by:
David S. Miller <davem@davemloft.net>
-
Stanislaw Gruszka authored
Remove check_plcp_health and check_ack_health ops methods, they are unneeded after iwlegacy driver split. Merge check health code into to iwl-rx.c and make functions static. Signed-off-by:
-
Stanislaw Gruszka authored
Add module ack_check, and plcp_check parameters. Ack_check is disabled by default since is proved that check ack health can cause troubles. Plcp_check is enabled by default. Signed-off-by:
-
- 25 Feb, 2011 1 commit
-
-
Johannes Berg authored
The return value of the tx operation is commonly misused by drivers, leading to errors. All drivers will drop frames if they fail to TX the frame, and they must also properly manage the queues (if they didn't, mac80211 would already warn). Removing the ability for drivers to return a BUSY value also allows significant cleanups of the TX TX handling code in mac80211. Note that this also fixes a bug in ath9k_htc, the old "return -1" there was wrong. Signed-off-by:
-
- 21 Feb, 2011 2 commits
-
-
Wey-Yi Guy authored
Intel WiFi devices 3945 and 4965 now have their own driver in the folder drivers/net/wireless/iwlegacy Add support to build these drivers independently of the driver for AGN devices. Selecting the 3945 builds iwl3945.ko and iwl_legacy.ko, and selecting the 4965 builds iwl4965.ko and iwl_legacy.ko. iwl-legacy.ko contains code shared between both devices. The 3945 is an ABG/BG device, with no support for 802.11n. The 4965 is a 2x3 ABGN device. Signed-off-by:
Meenakshi Venkataraman <meenakshi.venkataraman@intel.com> Acked-by:
-
Wey-Yi Guy authored
This reverts commit aa833c4b.
-
