1. 22 Aug, 2011 1 commit
  2. 22 Jul, 2011 3 commits
  3. 08 Jul, 2011 1 commit
  4. 07 Jul, 2011 1 commit
  5. 05 Jul, 2011 1 commit
  6. 01 Jun, 2011 3 commits
  7. 19 May, 2011 1 commit
  8. 16 May, 2011 1 commit
  9. 04 Apr, 2011 1 commit
  10. 15 Nov, 2010 1 commit
  11. 04 Jun, 2010 1 commit
  12. 02 Jun, 2010 1 commit
  13. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  14. 08 Feb, 2010 1 commit
  15. 29 Dec, 2009 1 commit
  16. 28 Dec, 2009 1 commit
  17. 23 Nov, 2009 1 commit
  18. 18 Nov, 2009 1 commit
    • Michael Buesch's avatar
      b43: Enforce DMA descriptor memory constraints · 9bd568a5
      Michael Buesch authored
      
      
      Enforce all device constraints on the descriptor memory region.
      
      There are several constraints on the descriptor memory, as documented
      in the specification. The current code does not enforce them and/or
      incorrectly enforces them.
      
      Those constraints are:
      - The address limitations on 30/32bit engines, that also apply to
        the skbs.
      - The 4k alignment requirement on 30/32bit engines.
      - The 8k alignment requirement on 64bit engines.
      Signed-off-by: default avatarMichael Buesch <mb@bu3sch.de>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      9bd568a5
  19. 11 Nov, 2009 1 commit
  20. 30 Oct, 2009 1 commit
    • Michael Buesch's avatar
      b43: Fix DMA TX bounce buffer copying · 9a3f4511
      Michael Buesch authored
      
      
      b43 allocates a bouncebuffer, if the supplied TX skb is in an invalid
      memory range for DMA.
      However, this is broken in that it fails to copy over some metadata to the
      new skb.
      
      This patch fixes three problems:
      * Failure to adjust the ieee80211_tx_info pointer to the new buffer.
        This results in a kmemcheck warning.
      * Failure to copy the skb cb, which contains ieee80211_tx_info, to the new skb.
        This results in breakage of various TX-status postprocessing (Rate control).
      * Failure to transfer the queue mapping.
        This results in the wrong queue being stopped on saturation and can result in queue overflow.
      Signed-off-by: default avatarMichael Buesch <mb@bu3sch.de>
      Tested-by: default avatarChristian Casteyde <casteyde.christian@free.fr>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      9a3f4511
  21. 23 Sep, 2009 1 commit
  22. 08 Sep, 2009 2 commits
  23. 20 Aug, 2009 1 commit
  24. 04 Aug, 2009 1 commit
    • Larry Finger's avatar
      b43: Work around mac80211 race condition · 18c69510
      Larry Finger authored
      As shown in http://thread.gmane.org/gmane.linux.kernel.wireless.general/36497
      
      ,
      mac80211 has a bug that allows a call to the TX routine after the queues have
      been stopped. This situation will only occur under extreme stress. Although
      b43 does not crash when this condition occurs, it does generate a WARN_ON and
      also logs a queue overrun message. This patch recognizes b43 is not at fault
      and logs a message only when the most verbose debugging mode is enabled. In
      the unlikely event that the queue is not stopped when the DMA queue becomes
      full, then a warning is issued.
      
      During testing of this patch with one output stream running repeated tcpperf
      writes and a second running a flood ping, this routine was entered with
      the DMA ring stopped about once per hour. The condition where the DMA queue is
      full but the ring has not been stopped has never been seen by me.
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      18c69510
  25. 10 Jun, 2009 1 commit
  26. 16 Apr, 2009 2 commits
    • Michael Buesch's avatar
      b43: Refresh RX poison on buffer recycling · cf68636a
      Michael Buesch authored
      
      
      The RX buffer poison needs to be refreshed, if we recycle an RX buffer,
      because it might be (partially) overwritten by some DMA operations.
      
      Cc: stable@kernel.org
      Cc: Francesco Gringoli <francesco.gringoli@ing.unibs.it>
      Signed-off-by: default avatarMichael Buesch <mb@bu3sch.de>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      cf68636a
    • Michael Buesch's avatar
      b43: Poison RX buffers · ec9a1d8c
      Michael Buesch authored
      
      
      This patch adds poisoning and sanity checking to the RX DMA buffers.
      This is used for protection against buggy hardware/firmware that raises
      RX interrupts without doing an actual DMA transfer.
      
      This mechanism protects against rare "bad packets" (due to uninitialized skb data)
      and rare kernel crashes due to uninitialized RX headers.
      
      The poison is selected to not match on valid frames and to be cheap for checking.
      
      The poison check mechanism _might_ trigger incorrectly, if we are voluntarily
      receiving frames with bad PLCP headers. However, this is nonfatal, because the
      chance of such a match is basically zero and in case it happens it just results
      in dropping the packet.
      Bad-PLCP RX defaults to off, and you should leave it off unless you want to listen
      to the latest news broadcasted by your microwave oven.
      
      This patch also moves the initialization of the RX-header "length" field in front of
      the mapping of the DMA buffer. The CPU should not touch the buffer after we mapped it.
      
      Cc: stable@kernel.org
      Reported-by: default avatarFrancesco Gringoli <francesco.gringoli@ing.unibs.it>
      Signed-off-by: default avatarMichael Buesch <mb@bu3sch.de>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      ec9a1d8c
  27. 07 Apr, 2009 3 commits
  28. 05 Mar, 2009 1 commit
  29. 27 Feb, 2009 4 commits