1. 30 Aug, 2007 15 commits
  2. 29 Aug, 2007 2 commits
  3. 28 Aug, 2007 1 commit
  4. 26 Aug, 2007 6 commits
  5. 23 Aug, 2007 2 commits
  6. 21 Aug, 2007 5 commits
    • Andy Whitcroft's avatar
      [IRDA] irda_nl_get_mode: always results in failure · 22117ea4
      Andy Whitcroft authored
      
      
      It seems an extraneous trailing ';' has slipped in to the error handling for a
      name registration failure causing the error path to trigger unconditionally.
      Signed-off-by: default avatarAndy Whitcroft <apw@shadowen.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarSamuel Ortiz <samuel@sortiz.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      22117ea4
    • Jesper Juhl's avatar
      [IRDA]: Avoid a label defined but not used warning in irda_init() · 2c20d72a
      Jesper Juhl authored
      
      
      Easily avoidable compiler warnings bug me.
      
      Building irmod without CONFIG_SYSCTL currently results in :
       net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used
      
      But that can easily be avoided by simply moving the label inside
      the existing "#ifdef CONFIG_SYSCTL" one line above it.
      
      This patch moves the label and buys us one less warning with no
      ill effects.
      Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2c20d72a
    • Wei Yongjun's avatar
      [IPV6]: Fix kernel panic while send SCTP data with IP fragments · 8984e41d
      Wei Yongjun authored
      If ICMP6 message with "Packet Too Big" is received after send SCTP DATA,
      kernel panic will occur when SCTP DATA is send again.
      
      This is because of a bad dest address when call to skb_copy_bits().
      
      The messages sequence is like this:
      
      Endpoint A                             Endpoint B
                                     <-------  SCTP DATA (size=1432)
      ICMP6 message ------->
      (Packet Too Big pmtu=1280)
                                     <-------  Resend SCTP DATA (size=1432)
      ------------kernel panic---------------
      
       printing eip:
      c05be62a
      *pde = 00000000
      Oops: 0002 [#1]
      SMP
      Modules linked in: scomm l2cap bluetooth ipv6 dm_mirror dm_mod video output sbs battery lp floppy sg i2c_piix4 i2c_core pcnet32 mii button ac parport_pc parport ide_cd cdrom serio_raw mptspi mptscsih mptbase scsi_transport_spi sd_mod scsi_mod ext3 jbd ehci_hcd ohci_hcd uhci_hcd
      CPU:    0
      EIP:    0060:[<c05be62a>]    Not tainted VLI
      EFLAGS: 00010282   (2.6.23-rc2 #1)
      EIP is at skb_copy_bits+0x4f/0x1ef
      eax: 000004d0   ebx: ce12a980   ecx: 00000134   edx: cfd5a880
      esi: c8246858   edi: 00000000   ebp: c0759b14   esp: c0759adc
      ds: 007b   es: 007b   fs: 00d8  gs: 0000  ss: 0068
      Process swapper (pid: 0, ti=c0759000 task=c06d0340 task.ti=c0713000)
      Stack: c0759b88 c0405867 ce12a980 c8bff838 c789c084 00000000 00000028 cfd5a880
             d09f1890 000005dc 0000007b ce12a980 cfd5a880 c8bff838 c0759b88 d09bc521
             000004d0 fffff96c 00000200 00000100 c0759b50 cfd5a880 00000246 c0759bd4
      Call Trace:
       [<c0405e1d>] show_trace_log_lvl+0x1a/0x2f
       [<c0405ecd>] show_stack_log_lvl+0x9b/0xa3
       [<c040608d>] show_registers+0x1b8/0x289
       [<c0406271>] die+0x113/0x246
       [<c0625dbc>] do_page_fault+0x4ad/0x57e
       [<c0624642>] error_code+0x72/0x78
       [<d09bc521>] ip6_output+0x8e5/0xab2 [ipv6]
       [<d09bcec1>] ip6_xmit+0x2ea/0x3a3 [ipv6]
       [<d0a3f2ca>] sctp_v6_xmit+0x248/0x253 [sctp]
       [<d0a3c934>] sctp_packet_transmit+0x53f/0x5ae [sctp]
       [<d0a34bf8>] sctp_outq_flush+0x555/0x587 [sctp]
       [<d0a34d3c>] sctp_retransmit+0xf8/0x10f [sctp]
       [<d0a3d183>] sctp_icmp_frag_needed+0x57/0x5b [sctp]
       [<d0a3ece2>] sctp_v6_err+0xcd/0x148 [sctp]
       [<d09cf1ce>] icmpv6_notify+0xe6/0x167 [ipv6]
       [<d09d009a>] icmpv6_rcv+0x7d7/0x849 [ipv6]
       [<d09be240>] ip6_input+0x1dc/0x310 [ipv6]
       [<d09be965>] ipv6_rcv+0x294/0x2df [ipv6]
       [<c05c3789>] netif_receive_skb+0x2d2/0x335
       [<c05c5733>] process_backlog+0x7f/0xd0
       [<c05c58f6>] net_rx_action+0x96/0x17e
       [<c042e722>] __do_softirq+0x64/0xcd
       [<c0406f37>] do_softirq+0x5c/0xac
       =======================
      Code: 00 00 29 ca 89 d0 2b 45 e0 89 55 ec 85 c0 7e 35 39 45 08 8b 55 e4 0f 4e 45 08 8b 75 e0 8b 7d dc 89 c1 c1 e9 02 03 b2 a0 00 00 00 <f3> a5 89 c1 83 e1 03 74 02 f3 a4 29 45 08 0f 84 7b 01 00 00 01
      EIP: [<c05be62a>] skb_copy_bits+0x4f/0x1ef SS:ESP 0068:c0759adc
      Kernel panic - not syncing: Fatal exception in interrupt
      
      Arnaldo says:
      ====================
      Thanks! I'm to blame for this one, problem was introduced in:
      
      b0e380b1
      
      
      
      @@ -761,7 +762,7 @@ slow_path:
                      /*
                       *      Copy a block of the IP datagram.
                       */
      -               if (skb_copy_bits(skb, ptr, frag->h.raw, len))
      +               if (skb_copy_bits(skb, ptr, skb_transport_header(skb),
      len))
                              BUG();
                      left -= len;
      ====================
      Signed-off-by: default avatarWei Yongjun <yjwei@cn.fujitsu.com>
      Acked-by: default avatarYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@ghostprotocols.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8984e41d
    • Herbert Xu's avatar
      [SNAP]: Check packet length before reading · d92a7db7
      Herbert Xu authored
      
      
      The snap_rcv code reads 5 bytes so we should make sure that
      we have 5 bytes in the head before proceeding.
      
      Based on diagnosis and fix by Evgeniy Polyakov, reported by
      Alan J. Wylie.
      
      Patch also kills the skb->sk assignment before kfree_skb
      since it's redundant.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d92a7db7
    • Gerrit Renker's avatar
      [DCCP]: Allocation in atomic context · 39dad26c
      Gerrit Renker authored
      
      
      This fixes the following bug reported in syslog:
      
      [ 4039.051658] BUG: sleeping function called from invalid context at /usr/src/davem-2.6/mm/slab.c:3032
      [ 4039.051668] in_atomic():1, irqs_disabled():0
      [ 4039.051670] INFO: lockdep is turned off.
      [ 4039.051674]  [<c0104c0f>] show_trace_log_lvl+0x1a/0x30
      [ 4039.051687]  [<c0104d4d>] show_trace+0x12/0x14
      [ 4039.051691]  [<c0104d65>] dump_stack+0x16/0x18
      [ 4039.051695]  [<c011371e>] __might_sleep+0xaf/0xbe
      [ 4039.051700]  [<c0157b66>] __kmalloc+0xb1/0xd0
      [ 4039.051706]  [<f090416f>] ccid2_hc_tx_alloc_seq+0x35/0xc3 [dccp_ccid2]
      [ 4039.051717]  [<f09048d6>] ccid2_hc_tx_packet_sent+0x27f/0x2d9 [dccp_ccid2]
      [ 4039.051723]  [<f085486b>] dccp_write_xmit+0x1eb/0x338 [dccp]
      [ 4039.051741]  [<f085603d>] dccp_sendmsg+0x113/0x18f [dccp]
      [ 4039.051750]  [<c03907fc>] inet_sendmsg+0x2e/0x4c
      [ 4039.051758]  [<c033a47d>] sock_aio_write+0xd5/0x107
      [ 4039.051766]  [<c015abc1>] do_sync_write+0xcd/0x11c
      [ 4039.051772]  [<c015b296>] vfs_write+0x118/0x11f
      [ 4039.051840]  [<c015b932>] sys_write+0x3d/0x64
      [ 4039.051845]  [<c0103e7c>] syscall_call+0x7/0xb
      [ 4039.051848]  =======================
      
      The problem was that GFP_KERNEL was used; fixed by using gfp_any().
      Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@ghostprotocols.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      39dad26c
  7. 19 Aug, 2007 1 commit
  8. 15 Aug, 2007 2 commits
  9. 14 Aug, 2007 6 commits
    • Adrian Bunk's avatar
      [VLAN] net/8021q/vlanproc.c: fix check-after-use · 16f3051b
      Adrian Bunk authored
      
      
      The Coverity checker spotted that we'd have already oops'ed if
      "vlandev" was NULL.
      Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      16f3051b
    • Adrian Bunk's avatar
      [NET]: Unexport dev_ethtool · 6f93b9c2
      Adrian Bunk authored
      
      
      This patch removes the no longer used EXPORT_SYMBOL(dev_ethtool).
      Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
      Acked-by: default avatarMatthew Wilcox <matthew@wil.cx>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6f93b9c2
    • Alexey Dobriyan's avatar
      [ECONET]: remove econet_packet_type on unload · 9c29a377
      Alexey Dobriyan authored
      
      
      Steps to reproduce:
      
      	modprobe econet
      	rmmod econet
      	modprobe econet
      
      Unable to handle kernel paging request at ffffffff8870a098 RIP: 
       [<ffffffff8040bfb8>] dev_add_pack+0x48/0x90
      PGD 203067 PUD 207063 PMD 7817f067 PTE 0
      Oops: 0002 [1] PREEMPT SMP 
      CPU 1 
      Modules linked in: econet [maaaany]
      Pid: 10671, comm: modprobe Not tainted 2.6.23-rc3-bloat #6
      RIP: 0010:[<ffffffff8040bfb8>]  [<ffffffff8040bfb8>] dev_add_pack+0x48/0x90
      RSP: 0000:ffff810076293df8  EFLAGS: 00010202
      RAX: ffffffff88659090 RBX: ffffffff88659060 RCX: ffffffff8870a090
      RDX: 0000000000000080 RSI: ffffffff805ec660 RDI: ffff810078ce4680
      RBP: ffff810076293e08 R08: 0000000000000002 R09: 0000000000000000
      R10: ffffffff8040bf88 R11: 0000000000000001 R12: ffff810076293e18
      R13: 000000000000001b R14: ffff810076dd06b0 R15: ffffffff886590c0
      FS:  00002b96a525dae0(0000) GS:ffff81007e0e2138(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      CR2: ffffffff8870a098 CR3: 000000007bb67000 CR4: 00000000000026e0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      Process modprobe (pid: 10671, threadinfo ffff810076292000, task ffff810078ce4680)
      Stack:  ffff810076dd06b0 0000000000000000 ffff810076293e38 ffffffff8865b180
       0000000000800000 0000000000000000 ffffffff886590c0 ffff810076dd01c8
       ffff810076293f78 ffffffff8026723c ffff810076293e48 ffffffff886590d8
      Call Trace:
       [<ffffffff8865b180>] :econet:econet_proto_init+0x180/0x1da
       [<ffffffff8026723c>] sys_init_module+0x15c/0x19e0
       [<ffffffff8020c13e>] system_call+0x7e/0x83
      
      
      Code: 48 89 41 08 48 89 82 e0 c5 5e 80 48 c7 c7 a0 08 5d 80 e8 f1 
      RIP  [<ffffffff8040bfb8>] dev_add_pack+0x48/0x90
       RSP <ffff810076293df8>
      CR2: ffffffff8870a098
      Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9c29a377
    • Alexey Dobriyan's avatar
      [AX25]: don't free pointers to statically allocated data · 9ac0be9d
      Alexey Dobriyan authored
      commit 8d5cf596
      
       started to add statically
      allocated ax25_protocol's to list. However kfree() was still in place waiting
      for unsuspecting ones on module removal.
      
      Steps to reproduce:
      
      	modprobe netrom
      	rmmod netrom
      
      P.S.: code would benefit greatly from list_add/list_del usage
      
      kernel BUG at mm/slab.c:592!
      invalid opcode: 0000 [1] PREEMPT SMP 
      CPU 0 
      Modules linked in: netrom ax25 af_packet usbcore rtc_cmos rtc_core rtc_lib
      Pid: 4477, comm: rmmod Not tainted 2.6.23-rc3-bloat #2
      RIP: 0010:[<ffffffff802ac646>]  [<ffffffff802ac646>] kfree+0x1c6/0x260
      RSP: 0000:ffff810079a05e48  EFLAGS: 00010046
      RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff81000000c000
      RDX: ffff81007e552458 RSI: 0000000000000000 RDI: 000000000000805d
      RBP: ffff810079a05e88 R08: 0000000000000001 R09: 0000000000000000
      R10: 0000000000000001 R11: 0000000000000000 R12: ffffffff8805d080
      R13: ffffffff8805d080 R14: 0000000000000000 R15: 0000000000000282
      FS:  00002b73fc98aae0(0000) GS:ffffffff805dc000(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      CR2: 000000000053f3b8 CR3: 0000000079ff2000 CR4: 00000000000006e0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      Process rmmod (pid: 4477, threadinfo ffff810079a04000, task ffff8100775aa480)
      Stack:  ffff810079a05e68 0000000000000246 ffffffff8804eca0 0000000000000000
       ffffffff8805d080 00000000000000cf 0000000000000000 0000000000000880
       ffff810079a05eb8 ffffffff8803ec90 ffff810079a05eb8 0000000000000000
      Call Trace:
       [<ffffffff8803ec90>] :ax25:ax25_protocol_release+0xa0/0xb0
       [<ffffffff88056ecb>] :netrom:nr_exit+0x6b/0xf0
       [<ffffffff80268bf0>] sys_delete_module+0x170/0x1f0
       [<ffffffff8025da35>] trace_hardirqs_on+0xd5/0x170
       [<ffffffff804835aa>] trace_hardirqs_on_thunk+0x35/0x37
       [<ffffffff8020c13e>] system_call+0x7e/0x83
      
      
      Code: 0f 0b eb fe 66 66 90 66 66 90 48 8b 52 10 48 8b 02 25 00 40 
      RIP  [<ffffffff802ac646>] kfree+0x1c6/0x260
       RSP <ffff810079a05e48>
      Kernel panic - not syncing: Fatal exception
      Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9ac0be9d
    • John W. Linville's avatar
      [PATCH] mac80211: probe for hidden SSIDs in pre-auth scan · b9bf1e60
      John W. Linville authored
      
      
      Probe for hidden SSIDs if initiating pre-authentication scan and SSID
      is set for STA interface.
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      b9bf1e60
    • Johannes Berg's avatar
      [PATCH] mac80211: fix tx status frame code · 7b7ed879
      Johannes Berg authored
      
      
      When I added the monitor for outgoing frames somehow a break
      statement slipped in. Remove it.
      
      Signed-off-by: Johannes Berg <johannes@sipsolutions.net
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      7b7ed879