1. 18 Nov, 2010 1 commit
    • Jiri Slaby's avatar
      ocfs2: fix memory leak · 1cf257f5
      Jiri Slaby authored
      Stanse found that o2hb_heartbeat_group_make_item leaks some memory on
      fail paths. Fix the paths by adding a new label and jump there.
      Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
      Cc: Mark Fasheh <mfasheh@suse.com>
      Cc: Joel Becker <joel.becker@oracle.com>
      Cc: ocfs2-devel@oss.oracle.com
      Cc: Alexander Viro <viro@zeniv.linux.org.uk>
      Cc: linux-fsdevel@vger.kernel.org
      Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
  2. 15 Oct, 2010 1 commit
  3. 09 Oct, 2010 1 commit
  4. 06 Oct, 2010 4 commits
    • Sunil Mushran's avatar
      · 43695d09
      Sunil Mushran authored
      ocfs2/cluster: Show per region heartbeat elapsed time
      This patch adds a per region debugfs file that shows the elapsed time
      since the time the o2hb timer was last armed.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
    • Sunil Mushran's avatar
      · d6aa1c7c
      Sunil Mushran authored
      ocfs2/cluster: Add mlogs for heartbeat up/down events
      This patch adds mlogs for o2hb up and down events.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
    • Sunil Mushran's avatar
      · 1f285305
      Sunil Mushran authored
      ocfs2/cluster: Create debugfs dir/files for each region
      This patch creates debugfs directory for each o2hb region and creates
      files to expose the region number and the per region live node bitmap.
      This information will be useful in debugging cluster issues.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
    • Sunil Mushran's avatar
      · a6de0136
      Sunil Mushran authored
      ocfs2/cluster: Create debugfs files for live, quorum and failed region bitmaps
      This patch prints the bitmaps of live, quorum and failed regions. This
      information will be useful in debugging cluster issues.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  5. 07 Oct, 2010 1 commit
    • Sunil Mushran's avatar
      · b1c5ebfb
      Sunil Mushran authored
      ocfs2/cluster: Maintain bitmap of failed regions
      In global heartbeat mode, we track the bitmap of regions that have seen
      heartbeat timeouts. We fence if the number of such regions is greater than
      or equal to half the number of quorum regions.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  6. 06 Oct, 2010 2 commits
    • Sunil Mushran's avatar
      · 43182d2a
      Sunil Mushran authored
      ocfs2/cluster: Maintain bitmap of quorum regions
      o2hb allows online adding of regions. However, a newly added region is not
      used in quorum calculations unless it has been added on all nodes. This patch
      tracks a bitmap of such quorum regions.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
    • Sunil Mushran's avatar
      · e7d656ba
      Sunil Mushran authored
      ocfs2/cluster: Track bitmap of live heartbeat regions
      A heartbeat region becomes live (or active) after a fixed number of (steady)
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  7. 07 Oct, 2010 1 commit
    • Sunil Mushran's avatar
      · 536f0741
      Sunil Mushran authored
      ocfs2/cluster: Track number of global heartbeat regions
      In global heartbeat mode, we have a upper limit for the number of active regions.
      This patch adds the facility to track the number of active global heartbeat
      regions and fails to start heartbeat if the number exceeds the maximum.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  8. 06 Oct, 2010 1 commit
    • Sunil Mushran's avatar
      · 823a637a
      Sunil Mushran authored
      ocfs2/cluster: Maintain live node bitmap per heartbeat region
      Currently we track a global livenode bitmap that keeps track of all nodes
      that are heartbeating in all regions.
      This patch adds the ability to track the livenode bitmap on a per region basis.
      We will use this facility in a later patch to allow us to withstand the loss of
      a minority number of regions.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  9. 07 Oct, 2010 2 commits
    • Sunil Mushran's avatar
      · 8ca8b0bb
      Sunil Mushran authored
      ocfs2/cluster: Reorganize o2hb debugfs init
      o2hb debugfs handling is reorganized to allow for easy expansion.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
    • Sunil Mushran's avatar
      · 0e105d37
      Sunil Mushran authored
      ocfs2/cluster: Check slots for unconfigured live nodes
      o2hb currently checks slots for configured nodes only. This patch makes
      it check the slots for the live nodes too to take care of a race in which
      a node is removed from the configuration but not from the live map.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  10. 06 Oct, 2010 1 commit
    • Sunil Mushran's avatar
      · 18c50cb0
      Sunil Mushran authored
      ocfs2/cluster: Print messages when adding/removing heartbeat regions
      Prints messages when the user adds or removes heartbeat regions in global
      heartbeat mode. These messages are useful when debugging cluster related issues.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  11. 07 Oct, 2010 2 commits
    • Sunil Mushran's avatar
      · b3c85c4c
      Sunil Mushran authored
      ocfs2/cluster: Get all heartbeat regions
      Export function in o2hb to get a list of heartbeat regions. It also adds an
      upper limit to the length of the heartbeat region name.
      o2hb_global_heartbeat_active() currently disables global heartbeat. It will
      be enabled in a later patch after all the code is added.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
    • Sunil Mushran's avatar
      · 54b5187b
      Sunil Mushran authored
      ocfs2/cluster: Add heartbeat mode configfs parameter
      Add heartbeat mode parameter to the configfs tree. This will be used
      to set/show the heartbeat mode. The user is free to toggle the mode
      between local and global as long as there is no active heartbeat region.
      Signed-off-by: default avatarSunil Mushran <sunil.mushran@oracle.com>
  12. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  13. 25 Jan, 2010 1 commit
  14. 23 Dec, 2009 1 commit
  15. 01 Oct, 2009 1 commit
  16. 22 May, 2009 1 commit
  17. 03 Apr, 2009 1 commit
  18. 06 Jan, 2009 1 commit
  19. 21 Oct, 2008 2 commits
  20. 17 Jul, 2008 2 commits
  21. 14 Jul, 2008 1 commit
    • Joel Becker's avatar
      configfs: Allow ->make_item() and ->make_group() to return detailed errors. · 11c3b792
      Joel Becker authored
      The configfs operations ->make_item() and ->make_group() currently
      return a new item/group.  A return of NULL signifies an error.  Because
      of this, -ENOMEM is the only return code bubbled up the stack.
      Multiple folks have requested the ability to return specific error codes
      when these operations fail.  This patch adds that ability by changing the
      ->make_item/group() ops to return an int.
      Also updated are the in-kernel users of configfs.
      Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
  22. 06 Nov, 2007 1 commit
  23. 19 Oct, 2007 1 commit
  24. 12 Oct, 2007 1 commit
  25. 10 Oct, 2007 1 commit
  26. 10 Jul, 2007 3 commits
  27. 02 May, 2007 1 commit
  28. 14 Mar, 2007 2 commits
  29. 07 Feb, 2007 1 commit
    • Philipp Reisner's avatar
      [PATCH] ocfs2 heartbeat: clean up bio submission code · b559292e
      Philipp Reisner authored
      As was already pointed out Mathieu Avila on Thu, 07 Sep 2006 03:15:25 -0700
      that OCFS2 is expecting bio_add_page() to add pages to BIOs in an easily
      predictable manner.
      That is not true, especially for devices with own merge_bvec_fn().
      Therefore OCFS2's heartbeat code is very likely to fail on such devices.
      Move the bio_put() call into the bio's bi_end_io() function. This makes the
      whole idea of trying to predict the behaviour of bio_add_page() unnecessary.
      Removed compute_max_sectors() and o2hb_compute_request_limits().
      Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
      Signed-off-by: default avatarMark Fasheh <mark.fasheh@oracle.com>