Commit f06cc7b2 authored by Yaowei Bai's avatar Yaowei Bai Committed by David S. Miller

net/inetdevice: bad_mask can be boolean

This patch makes bad_mask return bool due to this particular function
only using either one or zero as its return value.

No functional change.
Signed-off-by: default avatarYaowei Bai <>
Signed-off-by: default avatarDavid S. Miller <>
parent c3225164
......@@ -180,15 +180,15 @@ static __inline__ bool inet_ifa_match(__be32 addr, struct in_ifaddr *ifa)
* Check if a mask is acceptable.
static __inline__ int bad_mask(__be32 mask, __be32 addr)
static __inline__ bool bad_mask(__be32 mask, __be32 addr)
__u32 hmask;
if (addr & (mask = ~mask))
return 1;
return true;
hmask = ntohl(mask);
if (hmask & (hmask+1))
return 1;
return 0;
return true;
return false;
#define for_primary_ifa(in_dev) { struct in_ifaddr *ifa; \
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment