Commit f05795d3 authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Martin K. Petersen

scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

Add intermediate STARGET_REMOVE state to scsi_target_state to avoid
running into the BUG_ON() in scsi_target_reap(). The STARGET_REMOVE
state is only valid in the path from scsi_remove_target() to
scsi_target_destroy() indicating this target is going to be removed.

This re-fixes the problem introduced in commits bc3f02a7 ("[SCSI]
scsi_remove_target: fix softlockup regression on hot remove") and
40998193 ("scsi: restart list search after unlock in
scsi_remove_target") in a more comprehensive way.

[mkp: Included James' fix for scsi_target_destroy()]
Signed-off-by: default avatarJohannes Thumshirn <>
Fixes: 40998193
Reported-by: default avatarSergey Senozhatsky <>
Tested-by: default avatarSergey Senozhatsky <>
Reviewed-by: default avatarEwan D. Milne <>
Reviewed-by: default avatarHannes Reinecke <>
Reviewed-by: default avatarJames Bottomley <>
Signed-off-by: default avatarMartin K. Petersen <>
parent be2a266d
......@@ -319,6 +319,7 @@ static void scsi_target_destroy(struct scsi_target *starget)
struct Scsi_Host *shost = dev_to_shost(dev->parent);
unsigned long flags;
BUG_ON(starget->state == STARGET_DEL);
starget->state = STARGET_DEL;
spin_lock_irqsave(shost->host_lock, flags);
......@@ -1374,11 +1374,13 @@ restart:
spin_lock_irqsave(shost->host_lock, flags);
list_for_each_entry(starget, &shost->__targets, siblings) {
if (starget->state == STARGET_DEL ||
starget->state == STARGET_REMOVE ||
starget == last_target)
if (starget->dev.parent == dev || &starget->dev == dev) {
last_target = starget;
starget->state = STARGET_REMOVE;
spin_unlock_irqrestore(shost->host_lock, flags);
......@@ -248,6 +248,7 @@ scmd_printk(const char *, const struct scsi_cmnd *, const char *, ...);
enum scsi_target_state {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment