Commit e3c4269d authored by Michal Nazarewicz's avatar Michal Nazarewicz Committed by Steven Whitehouse

GFS2: fix potential NULL pointer dereference

Commit [e66cf161: GFS2: Use lockref for glocks] replaced call:
    atomic_read(&gi->gl->gl_ref) == 0
therefore changing how gl is accessed, from gi->gl to plan gl.
However, gl can be a NULL pointer, and so gi->gl needs to be
used instead (which is guaranteed not to be NULL because fo
the while loop checking that condition).
Signed-off-by: default avatarMichal Nazarewicz <>
Signed-off-by: default avatarSteven Whitehouse <>
parent 527d1511
......@@ -1899,7 +1899,8 @@ static int gfs2_glock_iter_next(struct gfs2_glock_iter *gi)
gi->nhash = 0;
/* Skip entries for other sb and dead entries */
} while (gi->sdp != gi->gl->gl_sbd || __lockref_is_dead(&gl->gl_lockref));
} while (gi->sdp != gi->gl->gl_sbd ||
return 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment