Commit e350a96e authored by Kenneth Williams's avatar Kenneth Williams Committed by David S. Miller
Browse files

team: Remove dead code

The deleted lines are called from a function which is called:
1) Only through __team_options_register via team_options_register and
2) Only during initialization / mode initialization when there are no
ports attached.
Therefore the ports list is guarenteed to be empty and this code will
never be executed.
Signed-off-by: default avatarKenneth Williams <>
Acked-by: default avatarJiri Pirko <>
Signed-off-by: default avatarDavid S. Miller <>
parent b1e8bc61
...@@ -176,7 +176,6 @@ static int __team_option_inst_add(struct team *team, struct team_option *option, ...@@ -176,7 +176,6 @@ static int __team_option_inst_add(struct team *team, struct team_option *option,
static int __team_option_inst_add_option(struct team *team, static int __team_option_inst_add_option(struct team *team,
struct team_option *option) struct team_option *option)
{ {
struct team_port *port;
int err; int err;
if (!option->per_port) { if (!option->per_port) {
...@@ -184,12 +183,6 @@ static int __team_option_inst_add_option(struct team *team, ...@@ -184,12 +183,6 @@ static int __team_option_inst_add_option(struct team *team,
if (err) if (err)
goto inst_del_option; goto inst_del_option;
} }
list_for_each_entry(port, &team->port_list, list) {
err = __team_option_inst_add(team, option, port);
if (err)
goto inst_del_option;
return 0; return 0;
inst_del_option: inst_del_option:
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment