Commit e0015489 authored by Herbert Xu's avatar Herbert Xu Committed by Linus Torvalds
Browse files

[PATCH] vmx: Fix register constraint in launch code

Both "=r" and "=g" breaks my build on i386:

  $ make
    CC [M]  drivers/kvm/vmx.o
  {standard input}: Assembler messages:
  {standard input}:3318: Error: bad register name `%sil'
  make[1]: *** [drivers/kvm/vmx.o] Error 1
  make: *** [_module_drivers/kvm] Error 2

The reason is that setbe requires an 8-bit register but "=r" does not
constrain the target register to be one that has an 8-bit version on

According to

the correct constraint is "=q".
Signed-off-by: default avatarHerbert Xu <>
Signed-off-by: default avatarLinus Torvalds <>
parent 46fd9061
......@@ -1824,7 +1824,7 @@ again:
"setbe %0 \n\t"
"popf \n\t"
: "=g" (fail)
: "=q" (fail)
: "r"(vcpu->launched), "d"((unsigned long)HOST_RSP),
[rax]"i"(offsetof(struct kvm_vcpu, regs[VCPU_REGS_RAX])),
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment