Commit d9d645f0 authored by Paolo 'Blaisorblade' Giarrusso's avatar Paolo 'Blaisorblade' Giarrusso Committed by Linus Torvalds
Browse files

[PATCH] uml: cleanup run_helper() API to fix a leak

Freeing the stack is left uselessly to the caller of run_helper in some cases
- this is taken from run_helper_thread, but here it is useless, so no caller
needs it and the only place where this happens has a potential leak - in case
of error neither run_helper() nor xterm_open() call free_stack().  At this
point passing a pointer is not needed - the stack pointer should be passed
directly, but this change is not done here.
Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <>
Cc: Jeff Dike <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent b2670eac
......@@ -136,8 +136,6 @@ int xterm_open(int input, int output, int primary, void *d,
if(data->stack == 0) free_stack(stack, 0);
if (data->direct_rcv) {
new = os_rcv_fd(fd, &data->helper_pid);
} else {
......@@ -50,7 +50,8 @@ static int helper_child(void *arg)
/* Returns either the pid of the child process we run or -E* on failure.
* XXX The alloc_stack here breaks if this is called in the tracing thread */
* XXX The alloc_stack here breaks if this is called in the tracing thread, so
* we need to receive a preallocated stack (a local buffer is ok). */
int run_helper(void (*pre_exec)(void *), void *pre_data, char **argv,
unsigned long *stack_out)
......@@ -113,10 +114,8 @@ out_close:
if (stack_out == NULL)
if ((stack_out == NULL) || (*stack_out == 0))
free_stack(stack, 0);
*stack_out = stack;
return ret;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment