Commit d8140b2f authored by Santosh Nayak's avatar Santosh Nayak Committed by David S. Miller
Browse files

netxen: Error return off by one in 'netxen_nic_set_pauseparam()'.



There are 'NETXEN_NIU_MAX_GBE_PORTS'  GBE ports. Port indexing starts
from zero.
Hence we should also return error for "port == NETXEN_NIU_MAX_GBE_PORTS"
Signed-off-by: default avatarSantosh Nayak <santoshprasadnayak@gmail.com>
parent 7011d085
...@@ -489,7 +489,7 @@ netxen_nic_get_pauseparam(struct net_device *dev, ...@@ -489,7 +489,7 @@ netxen_nic_get_pauseparam(struct net_device *dev,
int port = adapter->physical_port; int port = adapter->physical_port;
if (adapter->ahw.port_type == NETXEN_NIC_GBE) { if (adapter->ahw.port_type == NETXEN_NIC_GBE) {
if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS)) if ((port < 0) || (port >= NETXEN_NIU_MAX_GBE_PORTS))
return; return;
/* get flow control settings */ /* get flow control settings */
val = NXRD32(adapter, NETXEN_NIU_GB_MAC_CONFIG_0(port)); val = NXRD32(adapter, NETXEN_NIU_GB_MAC_CONFIG_0(port));
...@@ -534,7 +534,7 @@ netxen_nic_set_pauseparam(struct net_device *dev, ...@@ -534,7 +534,7 @@ netxen_nic_set_pauseparam(struct net_device *dev,
int port = adapter->physical_port; int port = adapter->physical_port;
/* read mode */ /* read mode */
if (adapter->ahw.port_type == NETXEN_NIC_GBE) { if (adapter->ahw.port_type == NETXEN_NIC_GBE) {
if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS)) if ((port < 0) || (port >= NETXEN_NIU_MAX_GBE_PORTS))
return -EIO; return -EIO;
/* set flow control */ /* set flow control */
val = NXRD32(adapter, NETXEN_NIU_GB_MAC_CONFIG_0(port)); val = NXRD32(adapter, NETXEN_NIU_GB_MAC_CONFIG_0(port));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment