Commit d687cbb7 authored by Rafał Miłecki's avatar Rafał Miłecki Committed by Johannes Berg

cfg80211: protect fools returning NULL in add_virtual_intf

Callback add_virtual_intf is supposed to return ERR_PTR and trying to
return NULL results in some "Unable to handle kernel paging request",
etc. As it may be complicated to debug & trace, let's catch it (WARN).
Signed-off-by: default avatarRafał Miłecki <>
Signed-off-by: default avatarJohannes Berg <>
parent c7ab5081
...@@ -2645,7 +2645,10 @@ static int nl80211_new_interface(struct sk_buff *skb, struct genl_info *info) ...@@ -2645,7 +2645,10 @@ static int nl80211_new_interface(struct sk_buff *skb, struct genl_info *info)
wdev = rdev_add_virtual_intf(rdev, wdev = rdev_add_virtual_intf(rdev,
nla_data(info->attrs[NL80211_ATTR_IFNAME]), nla_data(info->attrs[NL80211_ATTR_IFNAME]),
type, err ? NULL : &flags, &params); type, err ? NULL : &flags, &params);
if (IS_ERR(wdev)) { if (WARN_ON(!wdev)) {
return -EPROTO;
} else if (IS_ERR(wdev)) {
nlmsg_free(msg); nlmsg_free(msg);
return PTR_ERR(wdev); return PTR_ERR(wdev);
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment