Commit d4f82fd3 authored by Mitch A Williams's avatar Mitch A Williams Committed by Jeff Kirsher
Browse files

i40evf: Remove some scary log messages



These messages may be triggered during normal init of the driver if the
PF or FW take a long time to respond. There's nothing really wrong, so
don't freak people out logging messages.

If the communication channel really is dead, then we'll retry a few
times and give up. This will log a different more scary message that
should cause consternation. This allows the user to more easily detect a
genuine failure.

Change-ID: I6e2b758d4234a3a09c1015c82c8f2442a697cbdb
Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
Acked-by: default avatarShannon Nelson <shannon.nelson@intel.com>
Tested-by: default avatarJim Young <james.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent ff30cb6b
...@@ -2026,12 +2026,8 @@ static void i40evf_init_task(struct work_struct *work) ...@@ -2026,12 +2026,8 @@ static void i40evf_init_task(struct work_struct *work)
/* aq msg sent, awaiting reply */ /* aq msg sent, awaiting reply */
err = i40evf_verify_api_ver(adapter); err = i40evf_verify_api_ver(adapter);
if (err) { if (err) {
dev_info(&pdev->dev, "Unable to verify API version (%d), retrying\n", if (err == I40E_ERR_ADMIN_QUEUE_NO_WORK)
err);
if (err == I40E_ERR_ADMIN_QUEUE_NO_WORK) {
dev_info(&pdev->dev, "Resending request\n");
err = i40evf_send_api_ver(adapter); err = i40evf_send_api_ver(adapter);
}
goto err; goto err;
} }
err = i40evf_send_vf_config_msg(adapter); err = i40evf_send_vf_config_msg(adapter);
...@@ -2054,7 +2050,6 @@ static void i40evf_init_task(struct work_struct *work) ...@@ -2054,7 +2050,6 @@ static void i40evf_init_task(struct work_struct *work)
} }
err = i40evf_get_vf_config(adapter); err = i40evf_get_vf_config(adapter);
if (err == I40E_ERR_ADMIN_QUEUE_NO_WORK) { if (err == I40E_ERR_ADMIN_QUEUE_NO_WORK) {
dev_info(&pdev->dev, "Resending VF config request\n");
err = i40evf_send_vf_config_msg(adapter); err = i40evf_send_vf_config_msg(adapter);
goto err; goto err;
} }
......
...@@ -715,9 +715,6 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter, ...@@ -715,9 +715,6 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,
} }
return; return;
} }
if (v_opcode != adapter->current_op)
dev_info(&adapter->pdev->dev, "Pending op is %d, received %d\n",
adapter->current_op, v_opcode);
if (v_retval) { if (v_retval) {
dev_err(&adapter->pdev->dev, "%s: PF returned error %d to our request %d\n", dev_err(&adapter->pdev->dev, "%s: PF returned error %d to our request %d\n",
__func__, v_retval, v_opcode); __func__, v_retval, v_opcode);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment