Commit d4033afd authored by Joonsoo Kim's avatar Joonsoo Kim Committed by Linus Torvalds

mm, vmalloc: iterate vmap_area_list, instead of vmlist, in vmallocinfo()

This patch is a preparatory step for removing vmlist entirely.  For
above purpose, we change iterating a vmap_list codes to iterating a
vmap_area_list.  It is somewhat trivial change, but just one thing
should be noticed.

Using vmap_area_list in vmallocinfo() introduce ordering problem in SMP
system.  In s_show(), we retrieve some values from vm_struct.
vm_struct's values is not fully setup when va->vm is assigned.  Full
setup is notified by removing VM_UNLIST flag without holding a lock.
When we see that VM_UNLIST is removed, it is not ensured that vm_struct
has proper values in view of other CPUs.  So we need smp_[rw]mb for
ensuring that proper values is assigned when we see that VM_UNLIST is

Therefore, this patch not only change a iteration list, but also add a
appropriate smp_[rw]mb to right places.
Signed-off-by: default avatarJoonsoo Kim <>
Signed-off-by: default avatarJoonsoo Kim <>
Cc: Thomas Gleixner <>
Cc: "H. Peter Anvin" <>
Cc: Atsushi Kumagai <>
Cc: Chris Metcalf <>
Cc: Dave Anderson <>
Cc: Eric Biederman <>
Cc: Guan Xuetao <>
Cc: Ingo Molnar <>
Cc: Vivek Goyal <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent f98782dd
......@@ -1304,7 +1304,14 @@ static void insert_vmalloc_vmlist(struct vm_struct *vm)
struct vm_struct *tmp, **p;
* Before removing VM_UNLIST,
* we should make sure that vm has proper values.
* Pair with smp_rmb() in show_numa_info().
vm->flags &= ~VM_UNLIST;
for (p = &vmlist; (tmp = *p) != NULL; p = &tmp->next) {
if (tmp->addr >= vm->addr)
......@@ -2542,19 +2549,19 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms)
static void *s_start(struct seq_file *m, loff_t *pos)
loff_t n = *pos;
struct vm_struct *v;
struct vmap_area *va;
v = vmlist;
while (n > 0 && v) {
va = list_entry((&vmap_area_list)->next, typeof(*va), list);
while (n > 0 && &va->list != &vmap_area_list) {
v = v->next;
va = list_entry(va->, typeof(*va), list);
if (!n)
return v;
if (!n && &va->list != &vmap_area_list)
return va;
return NULL;
......@@ -2562,16 +2569,20 @@ static void *s_start(struct seq_file *m, loff_t *pos)
static void *s_next(struct seq_file *m, void *p, loff_t *pos)
struct vm_struct *v = p;
struct vmap_area *va = p, *next;
return v->next;
next = list_entry(va->, typeof(*va), list);
if (&next->list != &vmap_area_list)
return next;
return NULL;
static void s_stop(struct seq_file *m, void *p)
static void show_numa_info(struct seq_file *m, struct vm_struct *v)
......@@ -2582,6 +2593,11 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v)
if (!counters)
/* Pair with smp_wmb() in insert_vmalloc_vmlist() */
if (v->flags & VM_UNLIST)
memset(counters, 0, nr_node_ids * sizeof(unsigned int));
for (nr = 0; nr < v->nr_pages; nr++)
......@@ -2595,7 +2611,20 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v)
static int s_show(struct seq_file *m, void *p)
struct vm_struct *v = p;
struct vmap_area *va = p;
struct vm_struct *v;
if (va->flags & (VM_LAZY_FREE | VM_LAZY_FREEING))
return 0;
if (!(va->flags & VM_VM_AREA)) {
seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n",
(void *)va->va_start, (void *)va->va_end,
va->va_end - va->va_start);
return 0;
v = va->vm;
seq_printf(m, "0x%pK-0x%pK %7ld",
v->addr, v->addr + v->size, v->size);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment