Commit d2890dea authored by Sudarsana Reddy Kalluru's avatar Sudarsana Reddy Kalluru Committed by David S. Miller
Browse files

qede: Fix the static checker warnings.

Static checker warnings:
drivers/net/ethernet/qlogic/qede/qede_ethtool.c:435 qede_get_coalesce()
warn: passing casted pointer '&coal->rx_coalesce_usecs' to
'edev->ops->common->get_coalesce()' 32 vs 16.

The u32 pointer is being typecasted to u16 which may fail for big-endian

Fixes: d552fa84

 ("qede: Add support for coalescing config read/update.")
Reported-by: default avatarDan Carpenter <>
Signed-off-by: default avatarSudarsana Reddy Kalluru <>
Signed-off-by: default avatarDavid S. Miller <>
parent 51d99880
......@@ -430,11 +430,13 @@ static int qede_get_coalesce(struct net_device *dev,
struct ethtool_coalesce *coal)
struct qede_dev *edev = netdev_priv(dev);
u16 rxc, txc;
memset(coal, 0, sizeof(struct ethtool_coalesce));
(u16 *)&coal->rx_coalesce_usecs,
(u16 *)&coal->tx_coalesce_usecs);
edev->ops->common->get_coalesce(edev->cdev, &rxc, &txc);
coal->rx_coalesce_usecs = rxc;
coal->tx_coalesce_usecs = txc;
return 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment