Commit c9c37e2e authored by Al Viro's avatar Al Viro
Browse files

fuse: switch to iov_iter_get_pages()


Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent d22a943f
...@@ -1294,7 +1294,7 @@ static int fuse_get_user_pages(struct fuse_req *req, struct iov_iter *ii, ...@@ -1294,7 +1294,7 @@ static int fuse_get_user_pages(struct fuse_req *req, struct iov_iter *ii,
size_t nbytes = 0; /* # bytes already packed in req */ size_t nbytes = 0; /* # bytes already packed in req */
/* Special case for kernel I/O: can copy directly into the buffer */ /* Special case for kernel I/O: can copy directly into the buffer */
if (segment_eq(get_fs(), KERNEL_DS)) { if (ii->type & REQ_KERNEL) {
unsigned long user_addr = fuse_get_user_addr(ii); unsigned long user_addr = fuse_get_user_addr(ii);
size_t frag_size = fuse_get_frag_size(ii, *nbytesp); size_t frag_size = fuse_get_frag_size(ii, *nbytesp);
...@@ -1310,35 +1310,26 @@ static int fuse_get_user_pages(struct fuse_req *req, struct iov_iter *ii, ...@@ -1310,35 +1310,26 @@ static int fuse_get_user_pages(struct fuse_req *req, struct iov_iter *ii,
while (nbytes < *nbytesp && req->num_pages < req->max_pages) { while (nbytes < *nbytesp && req->num_pages < req->max_pages) {
unsigned npages; unsigned npages;
unsigned long user_addr = fuse_get_user_addr(ii); size_t start, end, frag_size;
unsigned offset = user_addr & ~PAGE_MASK;
size_t frag_size = fuse_get_frag_size(ii, *nbytesp - nbytes);
int ret;
unsigned n = req->max_pages - req->num_pages; unsigned n = req->max_pages - req->num_pages;
frag_size = min_t(size_t, frag_size, n << PAGE_SHIFT); ssize_t ret = iov_iter_get_pages(ii,
&req->pages[req->num_pages],
npages = (frag_size + offset + PAGE_SIZE - 1) >> PAGE_SHIFT; n * PAGE_SIZE, &start);
npages = clamp(npages, 1U, n);
ret = get_user_pages_fast(user_addr, npages, !write,
&req->pages[req->num_pages]);
if (ret < 0) if (ret < 0)
return ret; return ret;
npages = ret; iov_iter_advance(ii, ret);
frag_size = min_t(size_t, frag_size, nbytes += ret;
(npages << PAGE_SHIFT) - offset);
iov_iter_advance(ii, frag_size);
req->page_descs[req->num_pages].offset = offset; ret += start;
npages = (ret + PAGE_SIZE - 1) / PAGE_SIZE;
req->page_descs[req->num_pages].offset = start;
fuse_page_descs_length_init(req, req->num_pages, npages); fuse_page_descs_length_init(req, req->num_pages, npages);
req->num_pages += npages; req->num_pages += npages;
req->page_descs[req->num_pages - 1].length -= req->page_descs[req->num_pages - 1].length -=
(npages << PAGE_SHIFT) - offset - frag_size; (PAGE_SIZE - ret) & (PAGE_SIZE - 1);
nbytes += frag_size;
} }
if (write) if (write)
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment