Commit b0fc7c1a authored by Kalle Valo's avatar Kalle Valo
Browse files

ath6kl: fix regression in ath6kl_upload_board_file()

My patch 24fc32b3

 ("ath6kl: add ath6kl_bmi_write_hi32()") caused a regression
in ath6kl_upload_board_file() and the board_address variable was not
properly initialised in some cases:

ath6kl/init.c:1068:6: warning: ‘board_address’ may be used uninitialized
in this function

Most likely this broke ar6004 support but I can't test that right now.
Signed-off-by: default avatarKalle Valo <>
parent 17a7b16d
...@@ -1078,8 +1078,9 @@ static int ath6kl_upload_board_file(struct ath6kl *ar) ...@@ -1078,8 +1078,9 @@ static int ath6kl_upload_board_file(struct ath6kl *ar)
* writing board data. * writing board data.
*/ */
if (ar->hw.board_addr != 0) { if (ar->hw.board_addr != 0) {
board_address = ar->hw.board_addr;
ath6kl_bmi_write_hi32(ar, hi_board_data, ath6kl_bmi_write_hi32(ar, hi_board_data,
ar->hw.board_addr); board_address);
} else { } else {
ath6kl_bmi_read_hi32(ar, hi_board_data, &board_address); ath6kl_bmi_read_hi32(ar, hi_board_data, &board_address);
} }
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment