Commit a3c03992 authored by Chen Gang's avatar Chen Gang Committed by Linus Torvalds
Browse files

fs/proc/task_mmu.c: check the return value of mpol_to_str()

mpol_to_str() may fail, and not fill the buffer (e.g. -EINVAL), so need
check about it, or buffer may not be zero based, and next seq_printf()
will cause issue.

The failure return need after mpol_cond_put() to match get_vma_policy().
Signed-off-by: default avatarChen Gang <>
Cc: Cyrill Gorcunov <>
Cc: Mel Gorman <>
Cc: Andi Kleen <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 46496022
......@@ -1402,8 +1402,10 @@ static int show_numa_map(struct seq_file *m, void *v, int is_pid) = mm;
pol = get_vma_policy(task, vma, vma->vm_start);
mpol_to_str(buffer, sizeof(buffer), pol);
n = mpol_to_str(buffer, sizeof(buffer), pol);
if (n < 0)
return n;
seq_printf(m, "%08lx %s", vma->vm_start, buffer);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment