Commit a337499f authored by Denis V. Lunev's avatar Denis V. Lunev Committed by David S. Miller
Browse files

[IPV4]: Remove ifa != NULL check.



This is a callback registered to inet address notifier chain.
The check is useless as:
- ifa is always != NULL
- similar checks are abscent in all other notifiers.
Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2335f8ec
...@@ -3460,21 +3460,19 @@ static int velocity_resume(struct pci_dev *pdev) ...@@ -3460,21 +3460,19 @@ static int velocity_resume(struct pci_dev *pdev)
static int velocity_netdev_event(struct notifier_block *nb, unsigned long notification, void *ptr) static int velocity_netdev_event(struct notifier_block *nb, unsigned long notification, void *ptr)
{ {
struct in_ifaddr *ifa = (struct in_ifaddr *) ptr; struct in_ifaddr *ifa = (struct in_ifaddr *) ptr;
struct net_device *dev = ifa->ifa_dev->dev;
struct velocity_info *vptr;
unsigned long flags;
if (ifa) { spin_lock_irqsave(&velocity_dev_list_lock, flags);
struct net_device *dev = ifa->ifa_dev->dev; list_for_each_entry(vptr, &velocity_dev_list, list) {
struct velocity_info *vptr; if (vptr->dev == dev) {
unsigned long flags; velocity_get_ip(vptr);
break;
spin_lock_irqsave(&velocity_dev_list_lock, flags);
list_for_each_entry(vptr, &velocity_dev_list, list) {
if (vptr->dev == dev) {
velocity_get_ip(vptr);
break;
}
} }
spin_unlock_irqrestore(&velocity_dev_list_lock, flags);
} }
spin_unlock_irqrestore(&velocity_dev_list_lock, flags);
return NOTIFY_DONE; return NOTIFY_DONE;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment