Commit a09f69c4 authored by Andy Grover's avatar Andy Grover Committed by David S. Miller

RDS: Return -EINVAL if rds_rdma_pages returns an error

rds_cmsg_rdma_args would still return success even if rds_rdma_pages
returned an error (or overflowed).
Signed-off-by: default avatarAndy Grover <>
Signed-off-by: default avatarDavid S. Miller <>
parent 1b1f693d
......@@ -554,8 +554,10 @@ int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm,
nr_pages = rds_rdma_pages(args);
if (nr_pages < 0)
if (nr_pages < 0) {
ret = -EINVAL;
goto out;
pages = kcalloc(nr_pages, sizeof(struct page *), GFP_KERNEL);
if (!pages) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment