Commit 9eafa8cc authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

NFS: support EIOCBQUEUED return in direct write path

For async iocb's, the NFS direct write path now returns EIOCBQUEUED,
and calls aio_complete when all the requested writes are finished.  The
synchronous part of the NFS direct write path behaves exactly as it
was before.

Shared mapped NFS files will have some coherency difficulties when
accessed concurrently with aio+dio.  Will need to explore how this
is handled in the local file system case.

Test plan:
aio-stress with "-O". OraSim.
Signed-off-by: default avatarChuck Lever <>
Signed-off-by: default avatarTrond Myklebust <>
parent c89f2ee5
......@@ -441,8 +441,10 @@ static void nfs_direct_write_result(struct rpc_task *task, void *calldata)
atomic_set(&dreq->error, status);
if (unlikely(atomic_dec_and_test(&dreq->complete)))
if (unlikely(atomic_dec_and_test(&dreq->complete))) {
static const struct rpc_call_ops nfs_write_direct_ops = {
......@@ -548,8 +550,6 @@ static ssize_t nfs_direct_write(struct kiocb *iocb, unsigned long user_addr, siz
result = nfs_direct_wait(dreq);
rpc_clnt_sigunmask(clnt, &oldset);
return result;
......@@ -655,10 +655,6 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, const char __user *buf, size_t
(unsigned long) count, (long long) pos);
retval = -EINVAL;
if (!is_sync_kiocb(iocb))
goto out;
retval = generic_write_checks(file, &pos, &count, 0);
if (retval)
goto out;
......@@ -688,8 +684,18 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, const char __user *buf, size_t
retval = nfs_direct_write(iocb, (unsigned long) buf, count,
pos, pages, page_count);
* XXX: nfs_end_data_update() already ensures this file's
* cached data is subsequently invalidated. Do we really
* need to call invalidate_inode_pages2() again here?
* For aio writes, this invalidation will almost certainly
* occur before the writes complete. Kind of racey.
if (mapping->nrpages)
if (retval > 0)
iocb->ki_pos = pos + retval;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment