Commit 9cdfe2c7 authored by David L Stevens's avatar David L Stevens Committed by David S. Miller
Browse files

sunvnet: fix incorrect rcu_read_unlock() in vnet_start_xmit()



This patch removes an extra rcu_read_unlock() on an allocation failure
in vnet_skb_shape(). The needed rcu_read_unlock() is already done in
the out_dropped label.
Reported-by: default avatarRashmi Narasimhan <rashmi.narasimhan@oracle.com>
Signed-off-by: default avatarDavid L Stevens <david.stevens@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 58048e6d
......@@ -1317,10 +1317,8 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
skb = vnet_skb_shape(skb, 2);
if (unlikely(!skb)) {
rcu_read_unlock();
if (unlikely(!skb))
goto out_dropped;
}
if (skb->ip_summed == CHECKSUM_PARTIAL)
vnet_fullcsum(skb);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment