Commit 9779b72f authored by Chris Mason's avatar Chris Mason
Browse files

Btrfs: find smallest available device extent during chunk allocation



Allocating new block group is easy when the disk has plenty of space.
But things get difficult as the disk fills up, especially if
the FS has been run through btrfs-vol -b.  The balance operation
is likely to make the total bytes available on the device greater
than the largest extent we'll actually be able to allocate.

But the device extent allocation code incorrectly assumes that a device
with 5G free will be able to allocate a 5G extent.  It isn't normally a
problem because device extents don't get freed unless btrfs-vol -b
is run.

This fixes the device extent allocator to remember the largest free
extent it can find, and then uses that value as a fallback.
Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
parent 283bb197
...@@ -721,7 +721,8 @@ error: ...@@ -721,7 +721,8 @@ error:
*/ */
static noinline int find_free_dev_extent(struct btrfs_trans_handle *trans, static noinline int find_free_dev_extent(struct btrfs_trans_handle *trans,
struct btrfs_device *device, struct btrfs_device *device,
u64 num_bytes, u64 *start) u64 num_bytes, u64 *start,
u64 *max_avail)
{ {
struct btrfs_key key; struct btrfs_key key;
struct btrfs_root *root = device->dev_root; struct btrfs_root *root = device->dev_root;
...@@ -807,6 +808,10 @@ no_more_items: ...@@ -807,6 +808,10 @@ no_more_items:
if (last_byte < search_start) if (last_byte < search_start)
last_byte = search_start; last_byte = search_start;
hole_size = key.offset - last_byte; hole_size = key.offset - last_byte;
if (hole_size > *max_avail)
*max_avail = hole_size;
if (key.offset > last_byte && if (key.offset > last_byte &&
hole_size >= num_bytes) { hole_size >= num_bytes) {
*start = last_byte; *start = last_byte;
...@@ -1625,6 +1630,7 @@ static int __btrfs_grow_device(struct btrfs_trans_handle *trans, ...@@ -1625,6 +1630,7 @@ static int __btrfs_grow_device(struct btrfs_trans_handle *trans,
device->fs_devices->total_rw_bytes += diff; device->fs_devices->total_rw_bytes += diff;
device->total_bytes = new_size; device->total_bytes = new_size;
device->disk_total_bytes = new_size;
btrfs_clear_space_info_full(device->dev_root->fs_info); btrfs_clear_space_info_full(device->dev_root->fs_info);
return btrfs_update_device(trans, device); return btrfs_update_device(trans, device);
...@@ -2175,6 +2181,7 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans, ...@@ -2175,6 +2181,7 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
max_chunk_size); max_chunk_size);
again: again:
max_avail = 0;
if (!map || map->num_stripes != num_stripes) { if (!map || map->num_stripes != num_stripes) {
kfree(map); kfree(map);
map = kmalloc(map_lookup_size(num_stripes), GFP_NOFS); map = kmalloc(map_lookup_size(num_stripes), GFP_NOFS);
...@@ -2223,7 +2230,8 @@ again: ...@@ -2223,7 +2230,8 @@ again:
if (device->in_fs_metadata && avail >= min_free) { if (device->in_fs_metadata && avail >= min_free) {
ret = find_free_dev_extent(trans, device, ret = find_free_dev_extent(trans, device,
min_free, &dev_offset); min_free, &dev_offset,
&max_avail);
if (ret == 0) { if (ret == 0) {
list_move_tail(&device->dev_alloc_list, list_move_tail(&device->dev_alloc_list,
&private_devs); &private_devs);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment