Commit 957ee727 authored by Vikram Pandita's avatar Vikram Pandita Committed by Greg Kroah-Hartman
Browse files

serial: omap: fix software flow control

Software flow control register bits were not defined correctly.

Also clarify the IXON and IXOFF logic to reflect what userspace wants.

Tested-by: default avatarShubhrajyoti D <>
Signed-off-by: default avatarVikram Pandita <>
Signed-off-by: default avatarShubhrajyoti D <>
Acked-by: default avatarTony Lindgren <>
Signed-off-by: default avatarFelipe Balbi <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent a6b19c33
......@@ -42,10 +42,10 @@
/* Enable XON/XOFF flow control on output */
#define OMAP_UART_SW_TX 0x04
#define OMAP_UART_SW_TX 0x8
/* Enable XON/XOFF flow control on input */
#define OMAP_UART_SW_RX 0x04
#define OMAP_UART_SW_RX 0x2
......@@ -617,19 +617,19 @@ serial_omap_configure_xonxoff
* IXON Flag:
* Enable XON/XOFF flow control on output.
* Transmit XON1, XOFF1
* Flow control for OMAP.TX
* OMAP.RX should listen for XON/XOFF
if (termios->c_iflag & IXON)
up->efr |= OMAP_UART_SW_TX;
up->efr |= OMAP_UART_SW_RX;
* IXOFF Flag:
* Enable XON/XOFF flow control on input.
* Receiver compares XON1, XOFF1.
* Flow control for OMAP.RX
* OMAP.TX should send XON/XOFF
if (termios->c_iflag & IXOFF)
up->efr |= OMAP_UART_SW_RX;
up->efr |= OMAP_UART_SW_TX;
serial_out(up, UART_EFR, up->efr | UART_EFR_ECB);
serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment