Commit 8d1c3c07 authored by Tony Breeds's avatar Tony Breeds Committed by David S. Miller
Browse files

ixgbe: Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

GCC warns:
drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around
operand of '!' or change '&' to '&&' or '!' to '~'

Which I think is right.  Bracket to remove ambiguity.
Signed-off-by: default avatarTony Breeds <>
Signed-off-by: default avatarJeff Kirsher <>
Signed-off-by: default avatarDavid S. Miller <>
parent 04193058
......@@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
/* This will also work for DA Twinax connections */
adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment