Commit 8a08b934 authored by Aftab Hussain's avatar Aftab Hussain
Browse files

foobar comments

parent a3438057
......@@ -80,7 +80,7 @@ module foobar() {
// len(...)]*buf
//
// - Return values are "out", i.e., we assume an implicit [out] below, e.g.,
// [out, alloc(caller)], but we don't have to write it since it's a retun
// [out, alloc(caller)], but we don't have to write it since it's a return
// value and we can derive the "out"
//
// - [alloc(caller)] we cannot derive since it can be "bind"
......@@ -92,8 +92,9 @@ module foobar() {
}
rpc void free_foobardev(projection foobar_device_free_foobardev [dealloc(caller)] *dev);
// We also want to support scopes
//
// We also want to support scopes - in this way you can conveniently
// use the same variable names that would be invisible to the rest of
// the idl.
//{
// projection <struct foobar_device> foobar_device {};
// rpc void free_foobardev(projection foobar_device [dealloc(caller)] *dev);
......
......@@ -17,7 +17,7 @@ int register_foobar(struct foobar_device *dev)
dev->hw_features |= FOOBAR_IRQ_DELAY;
dev->features |= FOOBAR_SOFTIRQ_ENABLE;
dev->wanted_features = dev->features & dev->hw_features;
dev->wanted_features = dev->features & dev->hw_features; //Initial val of wanted_features does not matter.
if (dev->flags & FOO_LOOPBACK)
dev->hw_features |= FOOBAR_ZERO_COPY;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment