Commit 8811930d authored by Jens Axboe's avatar Jens Axboe Committed by Linus Torvalds
Browse files

splice: missing user pointer access verification

vmsplice_to_user() must always check the user pointer and length
with access_ok() before copying. Likewise, for the slow path of
copy_from_user_mmap_sem() we need to check that we may read from
the user region.
Signed-off-by: default avatarJens Axboe <>
Cc: Wojciech Purczynski <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
Signed-off-by: default avatarLinus Torvalds <>
parent 66191dc6
......@@ -1179,6 +1179,9 @@ static int copy_from_user_mmap_sem(void *dst, const void __user *src, size_t n)
int partial;
if (!access_ok(VERIFY_READ, src, n))
return -EFAULT;
partial = __copy_from_user_inatomic(dst, src, n);
......@@ -1387,6 +1390,11 @@ static long vmsplice_to_user(struct file *file, const struct iovec __user *iov,
if (unlikely(!access_ok(VERIFY_WRITE, base, len))) {
error = -EFAULT;
sd.len = 0;
sd.total_len = len;
sd.flags = flags;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment