Commit 83401eb4 authored by stephen hemminger's avatar stephen hemminger Committed by David S. Miller

bridge: fix race with topology change timer

A bridge should only send topology change notice if it is not
the root bridge. It is possible for message age timer to elect itself
as a new root bridge, and still have a topology change timer running
but waiting for bridge lock on other CPU.

Solve the race by checking if we are root bridge before continuing.
This was the root cause of the cases where br_send_tcn_bpdu would OOPS.
Reported-by: default avatarJerryKang <>
Signed-off-by: default avatarStephen Hemminger <>
Signed-off-by: default avatarDavid S. Miller <>
parent 488fc9af
......@@ -107,7 +107,7 @@ static void br_tcn_timer_expired(unsigned long arg)
br_debug(br, "tcn timer expired\n");
if (br->dev->flags & IFF_UP) {
if (!br_is_root_bridge(br) && (br->dev->flags & IFF_UP)) {
mod_timer(&br->tcn_timer,jiffies + br->bridge_hello_time);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment