Commit 82975bc6 authored by Andy Lutomirski's avatar Andy Lutomirski Committed by Linus Torvalds

uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME

x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set but
not on non-paranoid returns.  I suspect that this is a mistake and that
the code only works because int3 is paranoid.

Setting _TIF_NOTIFY_RESUME in the uprobe code was probably a workaround
for the x86 bug.  With that bug fixed, we can remove _TIF_NOTIFY_RESUME
from the uprobes code.
Reported-by: default avatarOleg Nesterov <>
Acked-by: default avatarSrikar Dronamraju <>
Acked-by: default avatarBorislav Petkov <>
Signed-off-by: default avatarAndy Lutomirski <>
Signed-off-by: default avatarLinus Torvalds <>
parent 90e362f4
......@@ -141,7 +141,7 @@ struct thread_info {
/* Only used for 64 bit */
/* flags to check in __switch_to() */
#define _TIF_WORK_CTXSW \
......@@ -1640,7 +1640,6 @@ bool uprobe_deny_signal(void)
if (__fatal_signal_pending(t) || arch_uprobe_xol_was_trapped(t)) {
utask->state = UTASK_SSTEP_TRAPPED;
set_tsk_thread_flag(t, TIF_UPROBE);
set_tsk_thread_flag(t, TIF_NOTIFY_RESUME);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment