Commit 8093315a authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

veth: extend device features



veth is lacking most modern facilities, like SG, checksums, TSO.

It makes sense to extend dev->features to get them, or GRO aggregation
is defeated by a forced segmentation.
Reported-by: default avatarAndrew Vagin <avagin@parallels.com>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2681128f
...@@ -238,6 +238,10 @@ static const struct net_device_ops veth_netdev_ops = { ...@@ -238,6 +238,10 @@ static const struct net_device_ops veth_netdev_ops = {
.ndo_set_mac_address = eth_mac_addr, .ndo_set_mac_address = eth_mac_addr,
}; };
#define VETH_FEATURES (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \
NETIF_F_HW_CSUM | NETIF_F_RXCSUM | NETIF_F_HIGHDMA | \
NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX)
static void veth_setup(struct net_device *dev) static void veth_setup(struct net_device *dev)
{ {
ether_setup(dev); ether_setup(dev);
...@@ -248,9 +252,10 @@ static void veth_setup(struct net_device *dev) ...@@ -248,9 +252,10 @@ static void veth_setup(struct net_device *dev)
dev->netdev_ops = &veth_netdev_ops; dev->netdev_ops = &veth_netdev_ops;
dev->ethtool_ops = &veth_ethtool_ops; dev->ethtool_ops = &veth_ethtool_ops;
dev->features |= NETIF_F_LLTX; dev->features |= NETIF_F_LLTX;
dev->features |= VETH_FEATURES;
dev->destructor = veth_dev_free; dev->destructor = veth_dev_free;
dev->hw_features = NETIF_F_HW_CSUM | NETIF_F_SG | NETIF_F_RXCSUM; dev->hw_features = VETH_FEATURES;
} }
/* /*
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment