Commit 78d29788 authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Linus Torvalds
Browse files

CRED: Fix kernel panic upon security_file_alloc() failure.

In get_empty_filp() since 2.6.29, file_free(f) is called with f->f_cred == NULL
when security_file_alloc() returned an error.  As a result, kernel will panic()
due to put_cred(NULL) call within RCU callback.

Fix this bug by assigning f->f_cred before calling security_file_alloc().

Signed-off-by: default avatarTetsuo Handa <>
Signed-off-by: default avatarDavid Howells <>
Signed-off-by: default avatarLinus Torvalds <>
parent bb5b583b
......@@ -125,13 +125,13 @@ struct file *get_empty_filp(void)
goto fail;
f->f_cred = get_cred(cred);
if (security_file_alloc(f))
goto fail_sec;
atomic_long_set(&f->f_count, 1);
f->f_cred = get_cred(cred);
/* f->f_version: 0 */
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment