Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
xcap
xcap-capability-linux
Commits
6754af64
Commit
6754af64
authored
Mar 22, 2010
by
Al Viro
Browse files
Convert simple loops over superblocks to list_for_each_entry_safe
Signed-off-by:
Al Viro
<
viro@zeniv.linux.org.uk
>
parent
8edd64bd
Changes
4
Hide whitespace changes
Inline
Side-by-side
fs/buffer.c
View file @
6754af64
...
...
@@ -562,12 +562,11 @@ repeat:
static
void
do_thaw_all
(
struct
work_struct
*
work
)
{
struct
super_block
*
sb
;
struct
super_block
*
sb
,
*
n
;
char
b
[
BDEVNAME_SIZE
];
spin_lock
(
&
sb_lock
);
restart:
list_for_each_entry
(
sb
,
&
super_blocks
,
s_list
)
{
list_for_each_entry_safe
(
sb
,
n
,
&
super_blocks
,
s_list
)
{
if
(
list_empty
(
&
sb
->
s_instances
))
continue
;
sb
->
s_count
++
;
...
...
@@ -578,8 +577,6 @@ restart:
bdevname
(
sb
->
s_bdev
,
b
));
up_read
(
&
sb
->
s_umount
);
spin_lock
(
&
sb_lock
);
if
(
__put_super_and_need_restart
(
sb
))
goto
restart
;
}
spin_unlock
(
&
sb_lock
);
kfree
(
work
);
...
...
fs/drop_caches.c
View file @
6754af64
...
...
@@ -35,11 +35,10 @@ static void drop_pagecache_sb(struct super_block *sb)
static
void
drop_pagecache
(
void
)
{
struct
super_block
*
sb
;
struct
super_block
*
sb
,
*
n
;
spin_lock
(
&
sb_lock
);
restart:
list_for_each_entry
(
sb
,
&
super_blocks
,
s_list
)
{
list_for_each_entry_safe
(
sb
,
n
,
&
super_blocks
,
s_list
)
{
if
(
list_empty
(
&
sb
->
s_instances
))
continue
;
sb
->
s_count
++
;
...
...
@@ -49,8 +48,7 @@ restart:
drop_pagecache_sb
(
sb
);
up_read
(
&
sb
->
s_umount
);
spin_lock
(
&
sb_lock
);
if
(
__put_super_and_need_restart
(
sb
))
goto
restart
;
__put_super
(
sb
);
}
spin_unlock
(
&
sb_lock
);
}
...
...
fs/quota/quota.c
View file @
6754af64
...
...
@@ -47,7 +47,7 @@ static int check_quotactl_permission(struct super_block *sb, int type, int cmd,
static
int
quota_sync_all
(
int
type
)
{
struct
super_block
*
sb
;
struct
super_block
*
sb
,
*
n
;
int
ret
;
if
(
type
>=
MAXQUOTAS
)
...
...
@@ -57,8 +57,7 @@ static int quota_sync_all(int type)
return
ret
;
spin_lock
(
&
sb_lock
);
restart:
list_for_each_entry
(
sb
,
&
super_blocks
,
s_list
)
{
list_for_each_entry_safe
(
sb
,
n
,
&
super_blocks
,
s_list
)
{
if
(
list_empty
(
&
sb
->
s_instances
))
continue
;
if
(
!
sb
->
s_qcop
||
!
sb
->
s_qcop
->
quota_sync
)
...
...
@@ -71,8 +70,7 @@ restart:
sb
->
s_qcop
->
quota_sync
(
sb
,
type
,
1
);
up_read
(
&
sb
->
s_umount
);
spin_lock
(
&
sb_lock
);
if
(
__put_super_and_need_restart
(
sb
))
goto
restart
;
__put_super
(
sb
);
}
spin_unlock
(
&
sb_lock
);
...
...
fs/super.c
View file @
6754af64
...
...
@@ -395,11 +395,10 @@ EXPORT_SYMBOL(drop_super);
*/
void
sync_supers
(
void
)
{
struct
super_block
*
sb
;
struct
super_block
*
sb
,
*
n
;
spin_lock
(
&
sb_lock
);
restart:
list_for_each_entry
(
sb
,
&
super_blocks
,
s_list
)
{
list_for_each_entry_safe
(
sb
,
n
,
&
super_blocks
,
s_list
)
{
if
(
list_empty
(
&
sb
->
s_instances
))
continue
;
if
(
sb
->
s_op
->
write_super
&&
sb
->
s_dirt
)
{
...
...
@@ -412,8 +411,7 @@ restart:
up_read
(
&
sb
->
s_umount
);
spin_lock
(
&
sb_lock
);
if
(
__put_super_and_need_restart
(
sb
))
goto
restart
;
__put_super
(
sb
);
}
}
spin_unlock
(
&
sb_lock
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment