From 6586b14c7bdec22f59dc749ead1d01d542d793b6 Mon Sep 17 00:00:00 2001 From: Guenter Roeck <guenter.roeck@ericsson.com> Date: Wed, 9 Mar 2011 07:23:54 -0800 Subject: [PATCH] hwmon: (pmbus) Use device specific function to read fan configuration Fan control implementation tends to be device specific, so start using the device specific function call to read fan configuration registers. Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> Reviewed-by: Tom Grennan <tom.grennan@ericsson.com> --- drivers/hwmon/pmbus_core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/pmbus_core.c b/drivers/hwmon/pmbus_core.c index 43ec1057c1f7..98799bab69ce 100644 --- a/drivers/hwmon/pmbus_core.c +++ b/drivers/hwmon/pmbus_core.c @@ -1295,9 +1295,7 @@ static void pmbus_add_fan_attributes(struct i2c_client *client, break; if (!pmbus_check_word_register(client, page, - pmbus_fan_registers[f]) - || !pmbus_check_byte_register(client, page, - pmbus_fan_config_registers[f])) + pmbus_fan_registers[f])) break; /* @@ -1305,7 +1303,7 @@ static void pmbus_add_fan_attributes(struct i2c_client *client, * Each fan configuration register covers multiple fans, * so we have to do some magic. */ - regval = pmbus_read_byte_data(client, page, + regval = _pmbus_read_byte_data(client, page, pmbus_fan_config_registers[f]); if (regval < 0 || (!(regval & (PB_FAN_1_INSTALLED >> ((f & 1) * 4))))) -- GitLab