Commit 5e5069b4 authored by Roger Luethi's avatar Roger Luethi Committed by David S. Miller
Browse files

ethtool: __ethtool_set_sg: check for function pointer before using it

__ethtool_set_sg does not check if dev->ethtool_ops->set_sg is defined
which can result in a NULL pointer dereference when ethtool is used to
change SG settings for drivers without SG support.
Signed-off-by: default avatarRoger Luethi <>
Reviewed-by: default avatarBen Hutchings <>
Signed-off-by: default avatarDavid S. Miller <>
parent 67c5c6cb
......@@ -1457,6 +1457,9 @@ static int __ethtool_set_sg(struct net_device *dev, u32 data)
int err;
if (!dev->ethtool_ops->set_sg)
if (data && !(dev->features & NETIF_F_ALL_CSUM))
return -EINVAL;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment