Commit 5db3a7b2 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: Debugging code for nfs_direct_(read|write)_schedule()



Make sure that we're doing our list accounting correctly.
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent a8881f5a
...@@ -339,6 +339,7 @@ static void nfs_direct_read_schedule(struct nfs_direct_req *dreq) ...@@ -339,6 +339,7 @@ static void nfs_direct_read_schedule(struct nfs_direct_req *dreq)
if (count < rsize) if (count < rsize)
bytes = count; bytes = count;
BUG_ON(list_empty(list));
data = list_entry(list->next, struct nfs_read_data, pages); data = list_entry(list->next, struct nfs_read_data, pages);
list_del_init(&data->pages); list_del_init(&data->pages);
...@@ -378,6 +379,7 @@ static void nfs_direct_read_schedule(struct nfs_direct_req *dreq) ...@@ -378,6 +379,7 @@ static void nfs_direct_read_schedule(struct nfs_direct_req *dreq)
count -= bytes; count -= bytes;
} while (count != 0); } while (count != 0);
BUG_ON(!list_empty(list));
} }
static ssize_t nfs_direct_read(struct kiocb *iocb, unsigned long user_addr, size_t count, loff_t pos, struct page **pages, unsigned int nr_pages) static ssize_t nfs_direct_read(struct kiocb *iocb, unsigned long user_addr, size_t count, loff_t pos, struct page **pages, unsigned int nr_pages)
...@@ -657,6 +659,7 @@ static void nfs_direct_write_schedule(struct nfs_direct_req *dreq, int sync) ...@@ -657,6 +659,7 @@ static void nfs_direct_write_schedule(struct nfs_direct_req *dreq, int sync)
if (count < wsize) if (count < wsize)
bytes = count; bytes = count;
BUG_ON(list_empty(list));
data = list_entry(list->next, struct nfs_write_data, pages); data = list_entry(list->next, struct nfs_write_data, pages);
list_move_tail(&data->pages, &dreq->rewrite_list); list_move_tail(&data->pages, &dreq->rewrite_list);
...@@ -697,6 +700,7 @@ static void nfs_direct_write_schedule(struct nfs_direct_req *dreq, int sync) ...@@ -697,6 +700,7 @@ static void nfs_direct_write_schedule(struct nfs_direct_req *dreq, int sync)
count -= bytes; count -= bytes;
} while (count != 0); } while (count != 0);
BUG_ON(!list_empty(list));
} }
static ssize_t nfs_direct_write(struct kiocb *iocb, unsigned long user_addr, size_t count, loff_t pos, struct page **pages, int nr_pages) static ssize_t nfs_direct_write(struct kiocb *iocb, unsigned long user_addr, size_t count, loff_t pos, struct page **pages, int nr_pages)
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment