Commit 59586e5a authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Linus Torvalds
Browse files

[PATCH] Don't export machine_restart, machine_halt, or machine_power_off.



machine_restart, machine_halt and machine_power_off are machine
specific hooks deep into the reboot logic, that modules
have no business messing with.  Usually code should be calling
kernel_restart, kernel_halt, kernel_power_off, or
emergency_restart. So don't export machine_restart,
machine_halt, and machine_power_off so we can catch buggy users.
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 16dcb4bb
......@@ -165,7 +165,6 @@ machine_restart(char *restart_cmd)
common_shutdown(LINUX_REBOOT_CMD_RESTART, restart_cmd);
}
EXPORT_SYMBOL(machine_restart);
void
machine_halt(void)
......@@ -173,7 +172,6 @@ machine_halt(void)
common_shutdown(LINUX_REBOOT_CMD_HALT, NULL);
}
EXPORT_SYMBOL(machine_halt);
void
machine_power_off(void)
......@@ -181,7 +179,6 @@ machine_power_off(void)
common_shutdown(LINUX_REBOOT_CMD_POWER_OFF, NULL);
}
EXPORT_SYMBOL(machine_power_off);
/* Used by sysrq-p, among others. I don't believe r9-r15 are ever
saved in the context it's used. */
......
......@@ -131,7 +131,6 @@ void machine_halt(void)
{
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
......@@ -139,7 +138,6 @@ void machine_power_off(void)
pm_power_off();
}
EXPORT_SYMBOL(machine_power_off);
void machine_restart(char * __unused)
{
......@@ -169,8 +167,6 @@ void machine_restart(char * __unused)
while (1);
}
EXPORT_SYMBOL(machine_restart);
void __show_regs(struct pt_regs *regs)
{
unsigned long flags = condition_codes(regs);
......
......@@ -103,9 +103,6 @@ void machine_power_off(void)
{
}
EXPORT_SYMBOL(machine_halt);
EXPORT_SYMBOL(machine_power_off);
void machine_restart(char * __unused)
{
/*
......@@ -136,8 +133,6 @@ void machine_restart(char * __unused)
while (1);
}
EXPORT_SYMBOL(machine_restart);
void show_regs(struct pt_regs * regs)
{
unsigned long flags;
......
......@@ -214,8 +214,6 @@ void machine_restart(char *cmd)
hard_reset_now();
}
EXPORT_SYMBOL(machine_restart);
/*
* Similar to machine_power_off, but don't shut off power. Add code
* here to freeze the system for e.g. post-mortem debug purpose when
......@@ -226,16 +224,12 @@ void machine_halt(void)
{
}
EXPORT_SYMBOL(machine_halt);
/* If or when software power-off is implemented, add code here. */
void machine_power_off(void)
{
}
EXPORT_SYMBOL(machine_power_off);
/*
* When a process does an "exec", machine state like FPU and debug
* registers need to be reset. This is a hook function for that.
......
......@@ -90,8 +90,6 @@ void machine_restart(char * __unused)
__asm__("jmp @@0");
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
local_irq_disable();
......@@ -99,8 +97,6 @@ void machine_halt(void)
for (;;);
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
local_irq_disable();
......@@ -108,8 +104,6 @@ void machine_power_off(void)
for (;;);
}
EXPORT_SYMBOL(machine_power_off);
void show_regs(struct pt_regs * regs)
{
printk("\nPC: %08lx Status: %02x",
......
......@@ -337,14 +337,10 @@ void machine_restart(char * __unused)
machine_real_restart(jump_to_bios, sizeof(jump_to_bios));
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
lapic_shutdown();
......@@ -355,5 +351,4 @@ void machine_power_off(void)
pm_power_off();
}
EXPORT_SYMBOL(machine_power_off);
......@@ -22,8 +22,6 @@ void machine_restart(char * __unused)
outb(PIIX4_RESET_VAL, PIIX4_RESET_PORT);
}
EXPORT_SYMBOL(machine_restart);
void machine_power_off(void)
{
unsigned short pm_status;
......@@ -43,10 +41,7 @@ void machine_power_off(void)
outl(PIIX_SPECIAL_STOP, 0xCFC);
}
EXPORT_SYMBOL(machine_power_off);
void machine_halt(void)
{
}
EXPORT_SYMBOL(machine_halt);
......@@ -278,8 +278,6 @@ machine_restart(char *cmd)
}
}
EXPORT_SYMBOL(machine_restart);
void
mca_nmi_hook(void)
{
......@@ -315,12 +313,9 @@ machine_halt(void)
machine_power_off();
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
if (pm_power_off)
pm_power_off();
}
EXPORT_SYMBOL(machine_power_off);
......@@ -807,16 +807,12 @@ machine_restart (char *restart_cmd)
(*efi.reset_system)(EFI_RESET_WARM, 0, 0, NULL);
}
EXPORT_SYMBOL(machine_restart);
void
machine_halt (void)
{
cpu_halt();
}
EXPORT_SYMBOL(machine_halt);
void
machine_power_off (void)
{
......@@ -825,4 +821,3 @@ machine_power_off (void)
machine_halt();
}
EXPORT_SYMBOL(machine_power_off);
......@@ -115,8 +115,6 @@ void machine_restart(char *__unused)
cpu_relax();
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
printk("Please push reset button!\n");
......@@ -124,15 +122,11 @@ void machine_halt(void)
cpu_relax();
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
/* M32R_FIXME */
}
EXPORT_SYMBOL(machine_power_off);
static int __init idle_setup (char *str)
{
if (!strncmp(str, "poll", 4)) {
......
......@@ -113,8 +113,6 @@ void machine_restart(char * __unused)
for (;;);
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
if (mach_halt)
......@@ -122,8 +120,6 @@ void machine_halt(void)
for (;;);
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
if (mach_power_off)
......@@ -131,8 +127,6 @@ void machine_power_off(void)
for (;;);
}
EXPORT_SYMBOL(machine_power_off);
void show_regs(struct pt_regs * regs)
{
printk("\n");
......
......@@ -80,8 +80,6 @@ void machine_restart(char * __unused)
for (;;);
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
if (mach_halt)
......@@ -89,8 +87,6 @@ void machine_halt(void)
for (;;);
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
if (mach_power_off)
......@@ -98,8 +94,6 @@ void machine_power_off(void)
for (;;);
}
EXPORT_SYMBOL(machine_power_off);
void show_regs(struct pt_regs * regs)
{
printk(KERN_NOTICE "\n");
......
......@@ -26,18 +26,13 @@ void machine_restart(char *command)
_machine_restart(command);
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
_machine_halt();
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
_machine_power_off();
}
EXPORT_SYMBOL(machine_power_off);
......@@ -150,8 +150,6 @@ void machine_restart(char *cmd)
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
/*
......@@ -160,8 +158,6 @@ void machine_halt(void)
*/
}
EXPORT_SYMBOL(machine_halt);
/*
* This routine is called from sys_reboot to actually turn off the
......@@ -187,8 +183,6 @@ void machine_power_off(void)
KERN_EMERG "Please power this system off now.");
}
EXPORT_SYMBOL(machine_power_off);
/*
* Create a kernel thread
......
......@@ -121,8 +121,6 @@ void machine_restart(char *cmd)
ppc_md.restart(cmd);
}
EXPORT_SYMBOL(machine_restart);
void machine_power_off(void)
{
#ifdef CONFIG_NVRAM
......@@ -131,8 +129,6 @@ void machine_power_off(void)
ppc_md.power_off();
}
EXPORT_SYMBOL(machine_power_off);
void machine_halt(void)
{
#ifdef CONFIG_NVRAM
......@@ -141,8 +137,6 @@ void machine_halt(void)
ppc_md.halt();
}
EXPORT_SYMBOL(machine_halt);
void (*pm_power_off)(void) = machine_power_off;
#ifdef CONFIG_TAU
......
......@@ -694,7 +694,6 @@ void machine_restart(char *cmd)
local_irq_disable();
while (1) ;
}
EXPORT_SYMBOL(machine_restart);
void machine_power_off(void)
{
......@@ -707,7 +706,6 @@ void machine_power_off(void)
local_irq_disable();
while (1) ;
}
EXPORT_SYMBOL(machine_power_off);
void machine_halt(void)
{
......@@ -720,7 +718,6 @@ void machine_halt(void)
local_irq_disable();
while (1) ;
}
EXPORT_SYMBOL(machine_halt);
static int ppc64_panic_event(struct notifier_block *this,
unsigned long event, void *ptr)
......
......@@ -299,24 +299,18 @@ void machine_restart(char *command)
_machine_restart(command);
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
console_unblank();
_machine_halt();
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
console_unblank();
_machine_power_off();
}
EXPORT_SYMBOL(machine_power_off);
static void __init
add_memory_hole(unsigned long start, unsigned long end)
{
......
......@@ -80,8 +80,6 @@ void machine_restart(char * __unused)
"mov.l @%1, %0" : : "r" (0x10000000), "r" (0x80000001));
}
EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
#if defined(CONFIG_SH_HS7751RVOIP)
......@@ -96,8 +94,6 @@ void machine_halt(void)
cpu_sleep();
}
EXPORT_SYMBOL(machine_halt);
void machine_power_off(void)
{
#if defined(CONFIG_SH_HS7751RVOIP)
......@@ -110,8 +106,6 @@ void machine_power_off(void)
#endif
}
EXPORT_SYMBOL(machine_power_off);
void show_regs(struct pt_regs * regs)
{
printk("\n");
......
......@@ -158,8 +158,6 @@ void machine_halt(void)
panic("Halt failed!");
}
EXPORT_SYMBOL(machine_halt);
void machine_restart(char * cmd)
{
char *p;
......@@ -180,8 +178,6 @@ void machine_restart(char * cmd)
panic("Reboot failed!");
}
EXPORT_SYMBOL(machine_restart);
void machine_power_off(void)
{
#ifdef CONFIG_SUN_AUXIO
......@@ -191,8 +187,6 @@ void machine_power_off(void)
machine_halt();
}
EXPORT_SYMBOL(machine_power_off);
static DEFINE_SPINLOCK(sparc_backtrace_lock);
void __show_backtrace(unsigned long fp)
......
......@@ -69,8 +69,6 @@ void machine_power_off(void)
machine_halt();
}
EXPORT_SYMBOL(machine_power_off);
#ifdef CONFIG_PCI
static int powerd(void *__unused)
{
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment