Commit 57699a40 authored by Ying Xue's avatar Ying Xue Committed by David S. Miller

rhashtable: Fix race in rhashtable_destroy() and use regular work_struct

When we put our declared work task in the global workqueue with
schedule_delayed_work(), its delay parameter is always zero.
Therefore, we should define a regular work in rhashtable structure
instead of a delayed work.

By the way, we add a condition to check whether resizing functions
are NULL before cancelling the work, avoiding to cancel an
uninitialized work.

Lastly, while we wait for all work items we submitted before to run
to completion with cancel_delayed_work(), ht->mutex has been taken in
rhashtable_destroy(). Moreover, cancel_delayed_work() doesn't return
until all work items are accomplished, and when work items are
scheduled, the work's function - rht_deferred_worker() will be called.
However, as rht_deferred_worker() also needs to acquire the lock,
deadlock might happen at the moment as the lock is already held before.
So if the cancel work function is moved out of the lock covered scope,
this will avoid the deadlock.

Fixes: 97defe1e ("rhashtable: Per bucket locks & deferred expansion/shrinking")
Signed-off-by: default avatarYing Xue <>
Cc: Thomas Graf <>
Acked-by: default avatarThomas Graf <>
Signed-off-by: default avatarDavid S. Miller <>
parent cbbd3667
...@@ -119,7 +119,7 @@ struct rhashtable { ...@@ -119,7 +119,7 @@ struct rhashtable {
atomic_t nelems; atomic_t nelems;
atomic_t shift; atomic_t shift;
struct rhashtable_params p; struct rhashtable_params p;
struct delayed_work run_work; struct work_struct run_work;
struct mutex mutex; struct mutex mutex;
bool being_destroyed; bool being_destroyed;
}; };
...@@ -485,7 +485,7 @@ static void rht_deferred_worker(struct work_struct *work) ...@@ -485,7 +485,7 @@ static void rht_deferred_worker(struct work_struct *work)
struct rhashtable *ht; struct rhashtable *ht;
struct bucket_table *tbl; struct bucket_table *tbl;
ht = container_of(work, struct rhashtable,; ht = container_of(work, struct rhashtable, run_work);
mutex_lock(&ht->mutex); mutex_lock(&ht->mutex);
tbl = rht_dereference(ht->tbl, ht); tbl = rht_dereference(ht->tbl, ht);
...@@ -507,7 +507,7 @@ static void rhashtable_wakeup_worker(struct rhashtable *ht) ...@@ -507,7 +507,7 @@ static void rhashtable_wakeup_worker(struct rhashtable *ht)
if (tbl == new_tbl && if (tbl == new_tbl &&
((ht->p.grow_decision && ht->p.grow_decision(ht, size)) || ((ht->p.grow_decision && ht->p.grow_decision(ht, size)) ||
(ht->p.shrink_decision && ht->p.shrink_decision(ht, size)))) (ht->p.shrink_decision && ht->p.shrink_decision(ht, size))))
schedule_delayed_work(&ht->run_work, 0); schedule_work(&ht->run_work);
} }
static void __rhashtable_insert(struct rhashtable *ht, struct rhash_head *obj, static void __rhashtable_insert(struct rhashtable *ht, struct rhash_head *obj,
...@@ -903,7 +903,7 @@ int rhashtable_init(struct rhashtable *ht, struct rhashtable_params *params) ...@@ -903,7 +903,7 @@ int rhashtable_init(struct rhashtable *ht, struct rhashtable_params *params)
get_random_bytes(&ht->p.hash_rnd, sizeof(ht->p.hash_rnd)); get_random_bytes(&ht->p.hash_rnd, sizeof(ht->p.hash_rnd));
if (ht->p.grow_decision || ht->p.shrink_decision) if (ht->p.grow_decision || ht->p.shrink_decision)
INIT_DEFERRABLE_WORK(&ht->run_work, rht_deferred_worker); INIT_WORK(&ht->run_work, rht_deferred_worker);
return 0; return 0;
} }
...@@ -921,11 +921,11 @@ void rhashtable_destroy(struct rhashtable *ht) ...@@ -921,11 +921,11 @@ void rhashtable_destroy(struct rhashtable *ht)
{ {
ht->being_destroyed = true; ht->being_destroyed = true;
mutex_lock(&ht->mutex); if (ht->p.grow_decision || ht->p.shrink_decision)
cancel_delayed_work(&ht->run_work); mutex_lock(&ht->mutex);
bucket_table_free(rht_dereference(ht->tbl, ht)); bucket_table_free(rht_dereference(ht->tbl, ht));
mutex_unlock(&ht->mutex); mutex_unlock(&ht->mutex);
} }
EXPORT_SYMBOL_GPL(rhashtable_destroy); EXPORT_SYMBOL_GPL(rhashtable_destroy);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment