Commit 574746dd authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: phy: properly report internal PHYs through sysfs

Internal PHYs may not have a valid PHY interface defined, which will
show up in sysfs as "". Add an explicit check of internal PHYs to report
their interface correctly.

Fixes: 3d055d8d

 ("net: phy: expose PHY device interface mode")
Signed-off-by: default avatarFlorian Fainelli <>
Signed-off-by: default avatarDavid S. Miller <>
parent 879ece6e
......@@ -553,8 +553,14 @@ static ssize_t
phy_interface_show(struct device *dev, struct device_attribute *attr, char *buf)
struct phy_device *phydev = to_phy_device(dev);
const char *mode = NULL;
return sprintf(buf, "%s\n", phy_modes(phydev->interface));
if (phy_is_internal(phydev))
mode = "internal";
mode = phy_modes(phydev->interface);
return sprintf(buf, "%s\n", mode);
static DEVICE_ATTR_RO(phy_interface);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment