Commit 54e2289a authored by Daniel Wagner's avatar Daniel Wagner Committed by Linus Torvalds
Browse files

scripts/gdb: use a generator instead of iterator for task list

The iterator does not return any task_struct from the thread_group list
because the first condition in the 'if not t or ...' will only be the
first time None.

Instead of keeping track of the state ourself in the next() function, we
fall back using Python's generator.
Signed-off-by: default avatarDaniel Wagner <>
Signed-off-by: default avatarJan Kiszka <>
Cc: Thomas Gleixner <>
Cc: Jason Wessel <>
Cc: Andi Kleen <>
Cc: Ben Widawsky <>
Cc: Borislav Petkov <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 2478a8a1
...@@ -18,38 +18,28 @@ from linux import utils ...@@ -18,38 +18,28 @@ from linux import utils
task_type = utils.CachedType("struct task_struct") task_type = utils.CachedType("struct task_struct")
def task_lists():
class TaskList: global task_type
def __init__(self): task_ptr_type = task_type.get_type().pointer()
global task_type init_task = gdb.parse_and_eval("init_task").address
self.task_ptr_type = task_type.get_type().pointer() t = g = init_task
self.init_task = gdb.parse_and_eval("init_task")
self.curr_group = self.init_task.address while True:
self.curr_task = None while True:
yield t
def __iter__(self):
return self t = utils.container_of(t['thread_group']['next'],
task_ptr_type, "thread_group")
def __next__(self): if t == g:
t = self.curr_task break
if not t or t == self.curr_group:
self.curr_group = \ t = g = utils.container_of(g['tasks']['next'],
utils.container_of(self.curr_group['tasks']['next'], task_ptr_type, "tasks")
self.task_ptr_type, "tasks") if t == init_task:
if self.curr_group == self.init_task.address: return
raise StopIteration
t = self.curr_task = self.curr_group
self.curr_task = \
self.task_ptr_type, "thread_group")
return t
def next(self):
return self.__next__()
def get_task_by_pid(pid): def get_task_by_pid(pid):
for task in TaskList(): for task in task_lists():
if int(task['pid']) == pid: if int(task['pid']) == pid:
return task return task
return None return None
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment